courgette/disassembler_elf_32_x86_unittest.cc - Issue 1969543002: Unified usage of vector<unique_ptr<T>>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: courgette/disassembler_elf_32_x86_unittest.cc

Issue 1969543002: Unified usage of vector<unique_ptr<T>> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: courgette/disassembler_elf_32_x86_unittest.cc

diff --git a/courgette/disassembler_elf_32_x86_unittest.cc b/courgette/disassembler_elf_32_x86_unittest.cc

index 7060dd342efe0cdd6a31841fc3d80c248f702da8..92f970d5252140691f9e92ee7a2a89f2a4b54f2c 100644

--- a/courgette/disassembler_elf_32_x86_unittest.cc

+++ b/courgette/disassembler_elf_32_x86_unittest.cc

@@ -98,7 +98,7 @@ void DisassemblerElf32X86Test::TestExe(const char* file_name,

// Flatten the list typed rel32 to a list of rel32 RVAs.

std::vector<RVA> rel32_list;

rel32_list.reserve(disassembler->Rel32Locations().size());

- for (TypedRVA* typed_rel32 : disassembler->Rel32Locations())

+ for (auto& typed_rel32 : disassembler->Rel32Locations())

rel32_list.push_back(typed_rel32->rva());

EXPECT_EQ(expected_abs_count, abs32_list.size());