Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 196953009: Revert 256563 "Reland r256396 Add views implementation for AXTre..." (Closed)

Created:
6 years, 9 months ago by Nico
Modified:
6 years, 9 months ago
Reviewers:
dtseng
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 256563 "Reland r256396 Add views implementation for AXTre..." Turned the chromeos lsan bot red: Indirect leak of 48 byte(s) in 1 object(s) allocated from: #0 0x480201 in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:54 #1 0x49e263 in ui::AXTreeSerializer\u003Cviews::View*>::SerializeChangedNodes(views::View*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:372 #2 0x49b75a in ui::AXTreeSerializer\u003Cviews::View*>::SerializeChanges(views::View*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:329 #3 0x49992d in views::AXTreeSourceViewsTest_SimpleSerialization_Test::TestBody() ui/views/accessibility/ax_tree_source_views_unittest.cc:75 #4 0xb859ba in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #5 0xb859ba in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #6 0xb874c9 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #7 0xb88243 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #8 0xb98e9a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #9 0xb984a0 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #10 0xb984a0 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #11 0xb51664 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #12 0xb51664 in base::TestSuite::Run() base/test/test_suite.cc:213 #13 0xb47d1d in Run base/callback.h:401 #14 0xb47d1d in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback\u003Cint ()> const&, int) base/test/launcher/unit_test_launcher.cc:494 #15 0x80bdba in main ui/views/run_all_unittests.cc:46 #16 0x7f0caf06376c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%2BLSan%20Tests%20%281%29/builds/222/steps/views_unittests/logs/SimpleSerialization > Reland r256396 Add views implementation for AXTreeSource. > > BUG=318758 > TBR=dtseng@chromium.org > > Review URL: https://codereview.chromium.org/196603003 TBR=dtseng@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256745

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -301 lines) Patch
M trunk/src/chrome/browser/ui/views/panels/panel_view.cc View 3 chunks +1 line, -7 lines 0 comments Download
M trunk/src/ui/accessibility/ax_tree_source.h View 1 chunk +1 line, -1 line 0 comments Download
D trunk/src/ui/views/accessibility/ax_tree_source_views.h View 1 chunk +0 lines, -52 lines 0 comments Download
D trunk/src/ui/views/accessibility/ax_tree_source_views.cc View 1 chunk +0 lines, -142 lines 0 comments Download
D trunk/src/ui/views/accessibility/ax_tree_source_views_unittest.cc View 1 chunk +0 lines, -85 lines 0 comments Download
M trunk/src/ui/views/views.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
M trunk/src/ui/views/widget/widget.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M trunk/src/ui/views/widget/widget_observer.h View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
6 years, 9 months ago (2014-03-13 04:31:50 UTC) #1
Nico
6 years, 9 months ago (2014-03-13 04:32:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r256745 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698