Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sandbox/BUILD.gn

Issue 1969503002: Address more TOOD(GYP) in GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« remoting/remoting_all.gyp ('K') | « remoting/remoting_all.gyp ('k') | sandbox/linux/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/BUILD.gn
diff --git a/sandbox/BUILD.gn b/sandbox/BUILD.gn
index dc3bb1c11a9a4252e8235bd834abd2e4026343fa..8ca3574e182b3b1422ac4a67a8ffeabb2be196df 100644
--- a/sandbox/BUILD.gn
+++ b/sandbox/BUILD.gn
@@ -9,13 +9,10 @@ group("sandbox") {
"//sandbox/win:sandbox",
]
} else if (is_mac) {
- # TODO(GYP): Make sandbox compile w/ 10.6 SDK.
- if (false) {
brettw 2016/05/10 19:51:33 I believe 10.6 support is gone. In any case, this
- public_deps = [
- "//sandbox/mac:sandbox",
- "//sandbox/mac:seatbelt",
- ]
- }
+ public_deps = [
+ "//sandbox/mac:sandbox",
+ "//sandbox/mac:seatbelt",
+ ]
} else if (is_linux || is_android) {
public_deps = [
"//sandbox/linux:sandbox",
« remoting/remoting_all.gyp ('K') | « remoting/remoting_all.gyp ('k') | sandbox/linux/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698