Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/BUILD.gn

Issue 1969503002: Address more TOOD(GYP) in GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/media_options.gni ('K') | « media/media_options.gni ('k') | remoting/BUILD.gn » ('j') | remoting/remoting_all.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/BUILD.gn
diff --git a/net/BUILD.gn b/net/BUILD.gn
index ac04e426cb4fa3b4412d082e783ecb3370c7f30f..abfca7e396f6b11f209e2d263592ab966b29f2b9 100644
--- a/net/BUILD.gn
+++ b/net/BUILD.gn
@@ -72,11 +72,6 @@ config("net_config") {
config("net_internal_config") {
defines = [
- # TODO(GYP) Note that the GYP file supports linux_link_kerberos (defaults to
brettw 2016/05/10 19:51:33 I suspect we never need the capability described i
- # 0) which implies that we run pkg_config on kerberos and link to that
- # rather than setting this define which will dynamically open it. That
- # doesn't seem to be set in the regular builds, so we're skipping this
- # capability here.
"DLOPEN_KERBEROS",
"NET_IMPLEMENTATION",
]
« media/media_options.gni ('K') | « media/media_options.gni ('k') | remoting/BUILD.gn » ('j') | remoting/remoting_all.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698