sandbox/BUILD.gn - Issue 1969503002: Address more TOOD(GYP) in GN build.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sandbox/BUILD.gn

Issue 1969503002: Address more TOOD(GYP) in GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: android Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 # Meta-target that forwards to the proper platform one.	5 # Meta-target that forwards to the proper platform one.

6 group("sandbox") {	6 group("sandbox") {

7 if (is_win) {	7 if (is_win) {

8 public_deps = [	8 public_deps = [

9 "//sandbox/win:sandbox",	9 "//sandbox/win:sandbox",

10 ]	10 ]

11 } else if (is_mac) {	11 } else if (is_mac) {

12 # TODO(GYP): Make sandbox compile w/ 10.6 SDK.	12 public_deps = [

13 if (false) {	13 "//sandbox/mac:sandbox",
brettw 2016/05/10 19:51:33 I believe 10.6 support is gone. In any case, this I believe 10.6 support is gone. In any case, this compiles.
14 public_deps = [	14 "//sandbox/mac:seatbelt",

15 "//sandbox/mac:sandbox",	15 ]

16 "//sandbox/mac:seatbelt",

17 ]

18 }

19 } else if (is_linux \|\| is_android) {	16 } else if (is_linux \|\| is_android) {

20 public_deps = [	17 public_deps = [

21 "//sandbox/linux:sandbox",	18 "//sandbox/linux:sandbox",

22 ]	19 ]

23 }	20 }

24 }	21 }

OLD	NEW