Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1969493002:
Set hard_dependency for media and media_features gyp targets (Closed)
DescriptionSet hard_dependency for media and media_features gyp targets
The media_features gyp target generates a header that is included by
many other files indirectly through media/base/video_codecs.h, so
both the main media target and media_features target must be marked
as hard_dependency: 1, to ensure the media_features.h header is
generated before being used anywhere.
BUG=606829
Committed: https://crrev.com/1652fefd7f5c0d7da557d26a0a107ed2acc25c31
Cr-Commit-Position: refs/heads/master@{#393049}
Patch Set 1 #Patch Set 2 : Add hard_dep for main media target #
Total comments: 1
Messages
Total messages: 18 (9 generated)
Description was changed from ========== Set hard_dependency for media_features gyp target Looks like other targets that generate headers are marked as hard_dependency and that ensures that the header is generated for real before being potentially used by other GYP targets that might not have a direct explicit dependency on media_features (only indirect dependency through other targets) and yet include media_features.h (usually also indirectly through other headers). BUG=606829 ========== to ========== Set hard_dependency for media_features gyp target Looks like other targets that generate headers are marked as hard_dependency and that ensures that the header is generated for real before being potentially used by other GYP targets that might not have a direct explicit dependency on media_features (only indirect dependency through other targets) and yet include media_features.h (usually also indirectly through other headers). BUG=606829 ==========
servolk@chromium.org changed reviewers: + wolenetz@chromium.org
servolk@chromium.org changed reviewers: + brettw@chromium.org
Description was changed from
==========
Set hard_dependency for media_features gyp target
Looks like other targets that generate headers are marked as
hard_dependency and that ensures that the header is generated for real
before being potentially used by other GYP targets that might not have a
direct explicit dependency on media_features (only indirect dependency
through other targets) and yet include media_features.h (usually also
indirectly through other headers).
BUG=606829
==========
to
==========
Set hard_dependency for media and media_features gyp targets
The media_features gyp target generates a header that is included by
many other files indirectly through media/base/video_codecs.h, so
both the main media target and media_features target must be marked
as hard_dependency: 1, to ensure the media_features.h header is
generated before being used anywhere.
BUG=606829
==========
servolk@chromium.org changed reviewers: + dpranke@chromium.org
On 2016/05/10 23:35:29, servolk wrote: ping
lgtm
The CQ bit was checked by servolk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969493002/20001
Message was sent while issue was closed.
Description was changed from
==========
Set hard_dependency for media and media_features gyp targets
The media_features gyp target generates a header that is included by
many other files indirectly through media/base/video_codecs.h, so
both the main media target and media_features target must be marked
as hard_dependency: 1, to ensure the media_features.h header is
generated before being used anywhere.
BUG=606829
==========
to
==========
Set hard_dependency for media and media_features gyp targets
The media_features gyp target generates a header that is included by
many other files indirectly through media/base/video_codecs.h, so
both the main media target and media_features target must be marked
as hard_dependency: 1, to ensure the media_features.h header is
generated before being used anywhere.
BUG=606829
==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from
==========
Set hard_dependency for media and media_features gyp targets
The media_features gyp target generates a header that is included by
many other files indirectly through media/base/video_codecs.h, so
both the main media target and media_features target must be marked
as hard_dependency: 1, to ensure the media_features.h header is
generated before being used anywhere.
BUG=606829
==========
to
==========
Set hard_dependency for media and media_features gyp targets
The media_features gyp target generates a header that is included by
many other files indirectly through media/base/video_codecs.h, so
both the main media target and media_features target must be marked
as hard_dependency: 1, to ensure the media_features.h header is
generated before being used anywhere.
BUG=606829
Committed: https://crrev.com/1652fefd7f5c0d7da557d26a0a107ed2acc25c31
Cr-Commit-Position: refs/heads/master@{#393049}
==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/1652fefd7f5c0d7da557d26a0a107ed2acc25c31 Cr-Commit-Position: refs/heads/master@{#393049}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1975483002/ by ananta@chromium.org. The reason for reverting is: Appears to cause Windows builds to fail. https://build.chromium.org/p/chromium/builders/Win/builds/43308 Please fix and reland.
Message was sent while issue was closed.
tapted@chromium.org changed reviewers: + tapted@chromium.org
Message was sent while issue was closed.
https://codereview.chromium.org/1969493002/diff/20001/media/media.gyp File media/media.gyp (right): https://codereview.chromium.org/1969493002/diff/20001/media/media.gyp#newcode97 media/media.gyp:97: ], I think export_dependent_settings also needs to include media_features - I'll add this to the patch and TBR since this is messing up the waterfall |
