Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Side by Side Diff: components/offline_pages/background/request_coordinator.cc

Issue 1969463002: Add a save page request to the request queue (and test it). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More CR feedback from FGorski Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/background/request_coordinator.h" 5 #include "components/offline_pages/background/request_coordinator.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h"
9 #include "components/offline_pages/background/offliner_factory.h" 10 #include "components/offline_pages/background/offliner_factory.h"
10 #include "components/offline_pages/background/offliner_policy.h" 11 #include "components/offline_pages/background/offliner_policy.h"
11 #include "components/offline_pages/background/save_page_request.h" 12 #include "components/offline_pages/background/save_page_request.h"
12 #include "components/offline_pages/offline_page_item.h" 13 #include "components/offline_pages/offline_page_item.h"
13 14
14 namespace offline_pages { 15 namespace offline_pages {
15 16
16 RequestCoordinator::RequestCoordinator( 17 RequestCoordinator::RequestCoordinator(std::unique_ptr<OfflinerPolicy> policy,
17 std::unique_ptr<OfflinerPolicy> policy, 18 std::unique_ptr<OfflinerFactory> factory,
18 std::unique_ptr<OfflinerFactory> factory) { 19 std::unique_ptr<RequestQueue> queue) {
19 // Do setup as needed. 20 // Do setup as needed.
20 // TODO(petewil): Assert policy not null. 21 // TODO(petewil): Assert policy not null.
21 policy_ = std::move(policy); 22 policy_ = std::move(policy);
22 factory_ = std::move(factory); 23 factory_ = std::move(factory);
24 queue_ = std::move(queue);
23 } 25 }
24 26
25 RequestCoordinator::~RequestCoordinator() {} 27 RequestCoordinator::~RequestCoordinator() {}
26 28
27 bool RequestCoordinator::SavePageLater( 29 bool RequestCoordinator::SavePageLater(
28 const GURL& url, const ClientId& client_id) { 30 const GURL& url, const ClientId& client_id) {
31 DVLOG(2) << "URL is " << url << " " << __FUNCTION__;
29 32
30 // TODO(petewil): We need a robust scheme for allocating new IDs. 33 // TODO(petewil): We need a robust scheme for allocating new IDs.
31 // TODO(petewil): Build a SavePageRequest. 34 static int64_t id = 0;
32 // TODO(petewil): Put the request on the request queue, nudge the scheduler. 35
36 // Build a SavePageRequest.
37 // TODO(petewil): Use something like base::Clock to help in testing.
38 offline_pages::SavePageRequest request(
39 id++, url, client_id, base::Time::Now());
40
41 // Put the request on the request queue.
42 queue_->AddRequest(request,
43 base::Bind(&RequestCoordinator::AddRequestResultCallback,
44 AsWeakPtr()));
45 // TODO: Do I need to persist the request in case the add fails?
33 46
34 return true; 47 return true;
35 } 48 }
36 49
50 void RequestCoordinator::AddRequestResultCallback(
51 RequestQueue::AddRequestResult result,
52 const SavePageRequest& request) {
53 DVLOG(2) << __FUNCTION__;
54
55 // Inform the scheduler that we have an outstanding task.
56 // TODO(petewil): implement.
57 }
58
37 bool RequestCoordinator::StartProcessing( 59 bool RequestCoordinator::StartProcessing(
38 const ProcessingDoneCallback& callback) { 60 const ProcessingDoneCallback& callback) {
39 return false; 61 return false;
40 } 62 }
41 63
42 void RequestCoordinator::StopProcessing() { 64 void RequestCoordinator::StopProcessing() {
43 } 65 }
44 66
45 } // namespace offline_pages 67 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698