Add a save page request to the request queue (and test it).

components/offline_pages/background/request_coordinator.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_COORDINATOR_H_
 #define COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_COORDINATOR_H_
 
 #include <memory>
 
 #include "base/callback.h"
 #include "base/macros.h"
 #include "components/keyed_service/core/keyed_service.h"
+#include "components/offline_pages/background/request_queue.h"
 #include "url/gurl.h"
 
 namespace offline_pages {
 
 struct ClientId;
 class OfflinerPolicy;
 class OfflinerFactory;
 class Offliner;
+class RequestQueue;

[fgorski, 2016/05/10 21:18:12]

since you are adding the header above, you don't need this.

[Pete Williamson, 2016/05/10 22:51:57]

Done.

 class SavePageRequest;
 
 // Coordinates queueing and processing save page later requests.
 class RequestCoordinator : public KeyedService {
  public:
   // Callback to report when the processing of a triggered task is complete.
   typedef base::Callback<void()> ProcessingDoneCallback;
 
   RequestCoordinator(std::unique_ptr<OfflinerPolicy> policy,
-                     std::unique_ptr<OfflinerFactory> factory);
+                     std::unique_ptr<OfflinerFactory> factory,
+                     std::unique_ptr<RequestQueue> queue);
 
   ~RequestCoordinator() override;
 
   // Queues |request| to later load and save when system conditions allow.
   // Returns true if the page could be queued successfully.
   bool SavePageLater(const GURL& url, const ClientId& client_id);
 
   // Starts processing of one or more queued save page later requests.
   // Returns whether processing was started and that caller should expect
   // a callback. If processing was already active, returns false.
   bool StartProcessing(const ProcessingDoneCallback& callback);
 
   // Stops the current request processing if active. This is a way for
   // caller to abort processing; otherwise, processing will complete on
   // its own. In either case, the callback will be called when processing
   // is stopped or complete.
   void StopProcessing();
 
+  // Returns the request queue used for requests.  Coordinator keeps ownership.
+  RequestQueue* GetQueue() { return queue_.get(); }
+
  private:
+  void AddRequestResultCallback(RequestQueue::AddRequestResult result,
+                                const SavePageRequest& request);
   // RequestCoordinator takes over ownership of the policy
   std::unique_ptr<OfflinerPolicy> policy_;
   // Factory is owned by the RequestCoordinator.
   std::unique_ptr<OfflinerFactory> factory_;
+  // The queue is also owned by this RequestCoordinator.

[dougarnett, 2016/05/10 20:23:34]

nit - unless I'm missing something, seems like all three of these members should
have comments that read the same - whether "takes over ownership" or "owned by"

[Pete Williamson, 2016/05/10 21:07:45]

Sure.  I was trying to avoid boring the reader by varying my wording, but it is
probably better for the reader if I am consistent than not boring.

[fgorski, 2016/05/10 21:18:12]

Good point. I suggest:
// Request queue. Used to <what it does>. Owned.

[Pete Williamson, 2016/05/10 22:51:57]

Done.

+  std::unique_ptr<RequestQueue> queue_;
 
   DISALLOW_COPY_AND_ASSIGN(RequestCoordinator);
 };
 
 }  // namespace offline_pages
 
 #endif  // COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_COORDINATOR_H_