Chromium Code Reviews

Issue 1969453003: Remove redundant GC mixin instance decl for AudioBufferSourceNode. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
Reviewers:
haraken, hongchan
CC:
chromium-reviews, blink-reviews, hongchan, Raymond Toy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant GC mixin instance decl for AudioBufferSourceNode. R= BUG= Committed: https://crrev.com/209798d3c24913ff8fe90a0ac7bf991bca2a8e89 Cr-Commit-Position: refs/heads/master@{#392747}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+0 lines, -1 line)
M third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h View 1 chunk +0 lines, -1 line 0 comments

Messages

Total messages: 12 (5 generated)
sof
please take a look.
4 years, 7 months ago (2016-05-10 19:09:50 UTC) #2
hongchan
lgtm
4 years, 7 months ago (2016-05-10 19:22:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969453003/1
4 years, 7 months ago (2016-05-10 20:57:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969453003/1
4 years, 7 months ago (2016-05-10 21:13:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 22:28:07 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/209798d3c24913ff8fe90a0ac7bf991bca2a8e89 Cr-Commit-Position: refs/heads/master@{#392747}
4 years, 7 months ago (2016-05-10 22:29:30 UTC) #11
haraken
4 years, 7 months ago (2016-05-10 23:23:30 UTC) #12
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine