Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Unified Diff: Source/core/rendering/style/GridCoordinate.h

Issue 196943026: [CSS Grid Layout] Support span in auto-placement algorithm (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add comment in areCellsEmpty() method Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/style/GridCoordinate.h
diff --git a/Source/core/rendering/style/GridCoordinate.h b/Source/core/rendering/style/GridCoordinate.h
index 1e3421ec370b71ad60d301a4eea450a521b788e8..fd675eed711d3321b2d49b6316dd90b913493413 100644
--- a/Source/core/rendering/style/GridCoordinate.h
+++ b/Source/core/rendering/style/GridCoordinate.h
@@ -114,6 +114,11 @@ struct GridSpan {
return initialPositionIndex == o.initialPositionIndex && finalPositionIndex == o.finalPositionIndex;
}
+ size_t spanningPositions() const
Julien - ping for review 2014/04/04 00:10:16 This name is also confusing for me. I would rather
+ {
+ return finalPositionIndex - initialPositionIndex + 1;
+ }
+
size_t initialPositionIndex;
size_t finalPositionIndex;
};
« Source/core/rendering/RenderGrid.cpp ('K') | « Source/core/rendering/RenderGrid.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698