Source/core/rendering/RenderGrid.h - Issue 196943026: [CSS Grid Layout] Support span in auto-placement algorithm

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderGrid.h

Issue 196943026: [CSS Grid Layout] Support span in auto-placement algorithm (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased patch after GridResolvedPosition was introduced Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css-grid-layout/grid-item-auto-placement-definite-span.html ('K') | « LayoutTests/fast/css-grid-layout/grid-item-spanning-resolution.html ('k') | Source/core/rendering/RenderGrid.cpp » ('j') | Source/core/rendering/RenderGrid.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderGrid.h

diff --git a/Source/core/rendering/RenderGrid.h b/Source/core/rendering/RenderGrid.h

index 418653fd7aaaa67504b7019c9bd6c764a14d03dd..52c0789ec84a1f0de7a7f4bee49f19ab54ce3993 100644

--- a/Source/core/rendering/RenderGrid.h

+++ b/Source/core/rendering/RenderGrid.h

@@ -77,10 +77,13 @@ private:

void resolveContentBasedTrackSizingFunctions(GridTrackSizingDirection, GridSizingData&, LayoutUnit& availableLogicalSpace);

void growGrid(GridTrackSizingDirection, size_t maximumPosition);

- void insertItemIntoGrid(RenderBox*, const GridResolvedPosition& rowTrack, const GridResolvedPosition& columnTrack);

void insertItemIntoGrid(RenderBox*, const GridCoordinate&);

void placeItemsOnGrid();

void populateExplicitGridAndOrderIterator();

+ bool checkEmptyCells(const GridCoordinate&) const;

+ PassOwnPtr<GridCoordinate> implicitEmptyGridAreaSpecifiedPositions(const RenderBox*, GridTrackSizingDirection, const GridSpan& specifiedPositions) const;

+ PassOwnPtr<GridCoordinate> emptyGridAreaSpecifiedPositions(const RenderBox*, GridTrackSizingDirection, const GridSpan& specifiedPositions) const;

+ void insertItemIntoGridGrowingIfNeeded(RenderBox*, const GridCoordinate&, GridTrackSizingDirection);

void placeSpecifiedMajorAxisItemsOnGrid(const Vector<RenderBox*>&);

void placeAutoMajorAxisItemsOnGrid(const Vector<RenderBox*>&);

void placeAutoMajorAxisItemOnGrid(RenderBox*);