Chromium Code Reviews Chromium Code Reviews
Issue 196943026:
[CSS Grid Layout] Support span in auto-placement algorithm (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/fast/css-grid-layout/grid-item-auto-placement-definite-span.html |
| diff --git a/LayoutTests/fast/css-grid-layout/grid-item-auto-placement-definite-span.html b/LayoutTests/fast/css-grid-layout/grid-item-auto-placement-definite-span.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..7aab0ebb82d8b9823986781ab695a231c49d6ecb |
| --- /dev/null |
| +++ b/LayoutTests/fast/css-grid-layout/grid-item-auto-placement-definite-span.html |
| @@ -0,0 +1,86 @@ |
| +<!DOCTYPE html> |
| +<html> |
| +<head> |
| + <link href="resources/grid.css" rel="stylesheet"> |
| + <style type="text/css"> |
|
Julien - ping for review
2014/03/20 18:33:14
No need for |type|.
|
| + .autoRowFirstColumnSpanning2 { |
| + background-color: maroon; |
| + grid-column: 1 / span 2; |
| + grid-row: auto; |
| + } |
| + |
| + .autoRowSecondColumnSpanning2 { |
| + background-color: olive; |
| + grid-column: 2 / span 2; |
| + grid-row: auto; |
| + } |
| + |
| + .autoRowFirstColumnSpanning3 { |
| + background-color: teal; |
| + grid-column: 1 / span 3; |
| + grid-row: auto; |
| + } |
| + |
| + .firstRowSpanning2AutoColumn { |
| + background-color: maroon; |
| + grid-column: auto; |
| + grid-row: 1 / span 2; |
| + height: 100%; |
| + } |
| + |
| + .secondRowSpanning2AutoColumn { |
| + background-color: olive; |
| + grid-column: auto; |
| + grid-row: 2 / span 2; |
| + height: 100%; |
| + } |
| + |
| + .firstRowSpanning3AutoColumn { |
| + background-color: teal; |
| + grid-column: auto; |
| + grid-row: 1 / span 3; |
| + height: 100%; |
| + } |
| + </style> |
| +</head> |
| +<body> |
| + <h1>Auto-placement definite span</h1> |
| + <p>Checks that span is supported in auto-placement for definite positions.</p> |
| + |
| + <h2>auto-flow row & spanning columns</h2> |
| + <div class="grid gridAutoFlowRow"> |
|
Julien - ping for review
2014/03/20 18:33:14
Shouldn't you define the grid's columns and rows i
|
| + <div class="autoRowFirstColumnSpanning2">autoRowFirstColumnSpanning2</div> |
| + <div class="autoRowSecondColumnSpanning2">autoRowSecondColumnSpanning2</div> |
| + <div class="autoRowFirstColumnSpanning3">autoRowFirstColumnSpanning3</div> |
| + <div class="autoRowAutoColumn">autoRowAutoColumn</div> |
| + <div class="autoRowAutoColumn">autoRowAutoColumn</div> |
| + </div> |
| + |
| + <h2>auto-flow row & spanning rows</h2> |
| + <div class="grid gridAutoFlowRow"> |
| + <div class="firstRowSpanning2AutoColumn">firstRowSpanning2AutoColumn</div> |
| + <div class="secondRowSpanning2AutoColumn">secondRowSpanning2AutoColumn</div> |
| + <div class="firstRowSpanning3AutoColumn">firstRowSpanning3AutoColumn</div> |
| + <div class="autoRowAutoColumn">autoRowAutoColumn</div> |
| + <div class="autoRowAutoColumn">autoRowAutoColumn</div> |
| + </div> |
| + |
| + <h2>auto-flow column & spanning rows</h2> |
| + <div class="grid gridAutoFlowColumn"> |
| + <div class="firstRowSpanning2AutoColumn">firstRowSpanning2AutoColumn</div> |
| + <div class="secondRowSpanning2AutoColumn">secondRowSpanning2AutoColumn</div> |
| + <div class="firstRowSpanning3AutoColumn">firstRowSpanning3AutoColumn</div> |
| + <div class="autoRowAutoColumn">autoRowAutoColumn</div> |
| + <div class="autoRowAutoColumn">autoRowAutoColumn</div> |
| + </div> |
| + |
| + <h2>auto-flow column & spanning columns</h2> |
| + <div class="grid gridAutoFlowColumn"> |
| + <div class="autoRowFirstColumnSpanning2">autoRowFirstColumnSpanning2</div> |
| + <div class="autoRowSecondColumnSpanning2">autoRowSecondColumnSpanning2</div> |
| + <div class="autoRowFirstColumnSpanning3">autoRowFirstColumnSpanning3</div> |
| + <div class="autoRowAutoColumn">autoRowAutoColumn</div> |
| + <div class="autoRowAutoColumn">autoRowAutoColumn</div> |
| + </div> |
| +</body> |
| +</html> |
