LayoutTests/fast/css-grid-layout/grid-item-spanning-resolution.html - Issue 196943026: [CSS Grid Layout] Support span in auto-placement algorithm

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css-grid-layout/grid-item-spanning-resolution.html

Issue 196943026: [CSS Grid Layout] Support span in auto-placement algorithm (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch for landing Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/grid-item-auto-placement-definite-span-expected.txt ('k') | Source/core/rendering/RenderGrid.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <link href="resources/grid.css" rel="stylesheet">	3 <link href="resources/grid.css" rel="stylesheet">

4 <style>	4 <style>

5 .grid {	5 .grid {

6 grid-template-columns: 40% 60%;	6 grid-template-columns: 40% 60%;

7 grid-template-rows: 30% 70%;	7 grid-template-rows: 30% 70%;

8 width: 400px;	8 width: 400px;

9 height: 300px;	9 height: 300px;

10 }	10 }

(...skipping 177 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
188	188

189 <div style="position: relative">	189 <div style="position: relative">

190 <div class="grid" id="bigGrid" data-expected-width="200" data-expected-height="1 00">	190 <div class="grid" id="bigGrid" data-expected-width="200" data-expected-height="1 00">

191 <div class="sizedToGridArea underflowSpanning" data-offset-x="0" data-offset -y="0" data-expected-width="100" data-expected-height="75"></div>	191 <div class="sizedToGridArea underflowSpanning" data-offset-x="0" data-offset -y="0" data-expected-width="100" data-expected-height="75"></div>

192 </div>	192 </div>

193	193

194 <!-- Check that the end span is ignored when two opposing spans are specified-->	194 <!-- Check that the end span is ignored when two opposing spans are specified-->

195 <div style="position: relative">	195 <div style="position: relative">

196 <div class="grid" id="fixedGrid" style="grid-auto-flow: row;">	196 <div class="grid" id="fixedGrid" style="grid-auto-flow: row;">

197 <div class="sizedToGridArea" style="grid-column: 1; grid-row: 1;" data-offse t-x="0" data-offset-y="0" data-expected-width="10" data-expected-height="15"></d iv>	197 <div class="sizedToGridArea" style="grid-column: 1; grid-row: 1;" data-offse t-x="0" data-offset-y="0" data-expected-width="10" data-expected-height="15"></d iv>

198 <div class="sizedToGridArea doubleSpan" data-offset-x="10" data-offset-y="0" data-expected-width="20" data-expected-height="15"></div>	198 <div class="sizedToGridArea doubleSpan" data-offset-x="10" data-offset-y="0" data-expected-width="60" data-expected-height="105"></div>

199 </div>	199 </div>

200	200

201 <div style="position: relative">	201 <div style="position: relative">

202 <div class="grid" id="fixedGrid" style="grid-auto-flow: column;">	202 <div class="grid" id="fixedGrid" style="grid-auto-flow: column;">

203 <div class="sizedToGridArea" style="grid-column: 1; grid-row: 1;" data-offse t-x="0" data-offset-y="0" data-expected-width="10" data-expected-height="15"></d iv>	203 <div class="sizedToGridArea" style="grid-column: 1; grid-row: 1;" data-offse t-x="0" data-offset-y="0" data-expected-width="10" data-expected-height="15"></d iv>

204 <div class="sizedToGridArea doubleSpan" data-offset-x="0" data-offset-y="15" data-expected-width="10" data-expected-height="30"></div>	204 <div class="sizedToGridArea doubleSpan" data-offset-x="0" data-offset-y="15" data-expected-width="30" data-expected-height="210"></div>

205 </div>	205 </div>

206 </body>	206 </body>

207 </html>	207 </html>

OLD	NEW