Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: pkg/code_transformers/lib/src/resolver_impl.dart

Issue 196943024: Adding some asset-related utilities to code_transformers (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/code_transformers/lib/src/resolver_impl.dart
diff --git a/pkg/code_transformers/lib/src/resolver_impl.dart b/pkg/code_transformers/lib/src/resolver_impl.dart
index df7a450b87c3064deee2a1aeb44697a86de05697..f702e505daccae54cf698ab1ca21d076440c74c5 100644
--- a/pkg/code_transformers/lib/src/resolver_impl.dart
+++ b/pkg/code_transformers/lib/src/resolver_impl.dart
@@ -21,6 +21,7 @@ import 'package:path/path.dart' as native_path;
import 'package:source_maps/refactor.dart';
import 'package:source_maps/span.dart' show SourceFile, Span;
+import 'assets.dart';
import 'resolver.dart';
// We should always be using url paths here since it's always Dart/pub code.
@@ -514,14 +515,7 @@ AssetId _resolve(AssetId source, String url, TransformLogger logger,
// Dart SDK libraries do not have assets.
if (uri.scheme == 'dart') return null;
- if (uri.host != '' || uri.scheme != '' || path.isAbsolute(url)) {
- logger.error('absolute paths not allowed: "$url"', span: span);
- return null;
- }
-
- var targetPath = path.normalize(
- path.join(path.dirname(source.path), url));
- return new AssetId(source.package, targetPath);
+ return uriToAssetId(source, url, logger, span);
}

Powered by Google App Engine
This is Rietveld 408576698