Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: build/common.gypi

Issue 196943020: Treat linker warnings as errors on all POSIX platforms (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 72eb96d94c07528ee98e90e0bdf56958f8bef7b5..bfc62e514006fd9c55b6668bbed8ef8474bb597e 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2972,6 +2972,7 @@
['os_posix==1', {
'target_defaults': {
'ldflags': [
+ '-Wl,--fatal-warnings',
Nico 2014/03/16 16:56:14 Should this only be done if werror% isn't empty?
'-Wl,-z,now',
'-Wl,-z,relro',
],
@@ -3049,7 +3050,6 @@
'conditions' : [
['OS=="android"', {
'ldflags': [
- '-Wl,--fatal-warnings',
# Only link with needed input sections. This is to avoid
# getting undefined reference to __cxa_bad_typeid in the CDU
# library.
@@ -3131,7 +3131,6 @@
'-fomit-frame-pointer',
],
'ldflags': [
- '-Wl,--fatal-warnings',
# Warn in case of text relocations.
'-Wl,--warn-shared-textrel',
],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698