Pass through "--filter" arguments from "git cl lint" to cpplint.py

Pass through "--filter" arguments from "git cl lint" to cpplint.py

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=256776

[tzik, 2014-03-13 04:10:55]

Hi.

"git cl lint" doesn't accept options for cpplint.py.
Can I make a change it to pass "--filter" through?

[Nico, 2014-03-13 04:21:18]

https://codereview.chromium.org/196943006/diff/20001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/196943006/diff/20001/git_cl.py#newcode1409
git_cl.py:1409: ['--filter=' + ','.join(options.filter)] + args + files)
if options.filter has its default value of [], this will pass

  ['--filter='] + args

which probably doesn't do the right thing, does it? Maybe

  command = args + files
  if options.filter
    command = ['--filter + ','.join...] + command
  ParseArguments(command)

is better?

[tzik, 2014-03-13 04:35:58]

https://codereview.chromium.org/196943006/diff/20001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/196943006/diff/20001/git_cl.py#newcode1409
git_cl.py:1409: ['--filter=' + ','.join(options.filter)] + args + files)
On 2014/03/13 04:21:18, Nico wrote:
> if options.filter has its default value of [], this will pass
> 
>   ['--filter='] + args
> 
> which probably doesn't do the right thing, does it? Maybe
> 
>   command = args + files
>   if options.filter
>     command = ['--filter + ','.join...] + command
>   ParseArguments(command)
> 
> is better?

Ah, right. Absence of "--filter" means different than just "--filter=".
Fixed.

[Nico, 2014-03-13 04:42:59]

lgtm

[tzik, 2014-03-13 07:14:29]

On 2014/03/13 04:42:59, Nico wrote:
> lgtm

Thanks!

iannucci: Could you take a look as a OWNER?

[iannucci, 2014-03-13 07:32:26]

lgtm

[tzik, 2014-03-13 07:38:59]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-03-13 07:39:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/196943006/40001

[commit-bot: I haz the power, 2014-03-13 07:40:56]

Change committed as 256776