Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 196943004: Add ASAN option to stand-alone gyp config. (Closed)

Created:
6 years, 9 months ago by Michael Achenbach
Modified:
6 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add ASAN option to stand-alone gyp config. BUG= R=jkummerow@chromium.org, jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19888

Patch Set 1 #

Total comments: 1

Patch Set 2 : Improvements... #

Patch Set 3 : More improvements. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M build/standalone.gypi View 1 2 2 chunks +17 lines, -0 lines 1 comment Download

Messages

Total messages: 9 (0 generated)
Michael Achenbach
PTAL - this seems to not have the desired effect yet. I tried: export CXX="$CLANG/clang++" ...
6 years, 9 months ago (2014-03-12 16:36:40 UTC) #1
jochen (gone - plz use gerrit)
https://codereview.chromium.org/196943004/diff/1/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/196943004/diff/1/build/standalone.gypi#newcode174 build/standalone.gypi:174: 'target_conditions': [ why only for the target toolset?
6 years, 9 months ago (2014-03-13 08:25:27 UTC) #2
Michael Achenbach
Patch 2 works when running: export CC="$CLANG/clang" export CXX="$CLANG/clang++" export CC_host="$CLANG/clang" export CXX_host="$CLANG/clang++" export LINK="$CLANG/clang++" ...
6 years, 9 months ago (2014-03-13 09:19:06 UTC) #3
Michael Achenbach
PTAL at patch 3. This works with: export CXX="$CLANG/clang++" export CXX_host="$CLANG/clang++" export LINK="$CLANG/clang++" export ASAN_SYMBOLIZER_PATH="$CLANG/llvm-symbolizer" ...
6 years, 9 months ago (2014-03-13 10:09:45 UTC) #4
jochen (gone - plz use gerrit)
https://codereview.chromium.org/196943004/diff/40001/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/196943004/diff/40001/build/standalone.gypi#newcode174 build/standalone.gypi:174: 'target_defaults': { does it also work if you use ...
6 years, 9 months ago (2014-03-13 10:12:45 UTC) #5
Michael Achenbach
It seems to work also like this: ['asan==1', { 'target_defaults': { 'target_conditions': [ [ '_toolset=="target"', ...
6 years, 9 months ago (2014-03-13 10:18:51 UTC) #6
jochen (gone - plz use gerrit)
On 2014/03/13 10:18:51, Michael Achenbach wrote: > It seems to work also like this: > ...
6 years, 9 months ago (2014-03-13 10:27:37 UTC) #7
Jakob Kummerow
LGTM too.
6 years, 9 months ago (2014-03-13 10:28:30 UTC) #8
Michael Achenbach
6 years, 9 months ago (2014-03-13 10:37:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 manually as r19888 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698