Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 196943002: Fix HIsSmiAndBranch::KnownSuccessorBlock() by deleting it (Closed)

Created:
6 years, 9 months ago by Jakob Kummerow
Modified:
6 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Fix HIsSmiAndBranch::KnownSuccessorBlock() by deleting it Constants can still change their representation, so we cannot determine reachability of blocks based on their Smi-ness BUG=chromium:351320 LOG=y R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19836

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -13 lines) Patch
M src/hydrogen-instructions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +0 lines, -11 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-351320.js View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
PTAL. There are other options we could consider, such as updating HIsSmiAndBranch's RequiredInputRepresentation after deciding ...
6 years, 9 months ago (2014-03-12 10:05:28 UTC) #1
Yang
lgtm
6 years, 9 months ago (2014-03-12 10:10:29 UTC) #2
Jakob Kummerow
6 years, 9 months ago (2014-03-12 10:14:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19836 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698