src/full-codegen/ia32/full-codegen-ia32.cc - Issue 1969423002: [Interpreter] Remove InterpreterExitTrampoline and replace with returning to the entry trampoline.

Unified Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 1969423002: [Interpreter] Remove InterpreterExitTrampoline and replace with returning to the entry trampoline. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Review comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/full-codegen/ia32/full-codegen-ia32.cc

diff --git a/src/full-codegen/ia32/full-codegen-ia32.cc b/src/full-codegen/ia32/full-codegen-ia32.cc

index b408a4850cef1cf74fc5b61bc050834845ba002e..a8c24520b666898c2d3da657bfb9fb2c78e5ae25 100644

--- a/src/full-codegen/ia32/full-codegen-ia32.cc

+++ b/src/full-codegen/ia32/full-codegen-ia32.cc

@@ -168,7 +168,8 @@ void FullCodeGenerator::Generate() {

__ push(edi);

__ Push(info->scope()->GetScopeInfo(info->isolate()));

__ CallRuntime(Runtime::kNewScriptContext);

- PrepareForBailoutForId(BailoutId::ScriptContext(), TOS_REG);

+ PrepareForBailoutForId(BailoutId::ScriptContext(),

+ BailoutState::TOS_REGISTER);

// The new target value is not used, clobbering is safe.

DCHECK_NULL(info->scope()->new_target_var());

} else {

@@ -227,7 +228,8 @@ void FullCodeGenerator::Generate() {

// Register holding this function and new target are both trashed in case we

// bailout here. But since that can happen only when new target is not used

// and we allocate a context, the value of |function_in_register| is correct.

- PrepareForBailoutForId(BailoutId::FunctionContext(), NO_REGISTERS);

+ PrepareForBailoutForId(BailoutId::FunctionContext(),

+ BailoutState::NO_REGISTERS);

// Possibly set up a local binding to the this function which is used in

// derived constructors with super calls.

@@ -289,7 +291,8 @@ void FullCodeGenerator::Generate() {

}

// Visit the declarations and body.

- PrepareForBailoutForId(BailoutId::FunctionEntry(), NO_REGISTERS);

+ PrepareForBailoutForId(BailoutId::FunctionEntry(),

+ BailoutState::NO_REGISTERS);

{

Comment cmnt(masm_, "[ Declarations");

VisitDeclarations(scope()->declarations());

@@ -302,7 +305,8 @@ void FullCodeGenerator::Generate() {

{

Comment cmnt(masm_, "[ Stack check");

- PrepareForBailoutForId(BailoutId::Declarations(), NO_REGISTERS);

+ PrepareForBailoutForId(BailoutId::Declarations(),

+ BailoutState::NO_REGISTERS);

Label ok;

ExternalReference stack_limit =

ExternalReference::address_of_stack_limit(isolate());

@@ -369,11 +373,11 @@ void FullCodeGenerator::EmitBackEdgeBookkeeping(IterationStatement* stmt,

EmitProfilingCounterReset();

__ bind(&ok);

- PrepareForBailoutForId(stmt->EntryId(), NO_REGISTERS);

+ PrepareForBailoutForId(stmt->EntryId(), BailoutState::NO_REGISTERS);

// Record a mapping of the OSR id to this PC. This is used if the OSR

// entry becomes the target of a bailout. We don't expect it to be, but

// we want it to work if it is.

- PrepareForBailoutForId(stmt->OsrEntryId(), NO_REGISTERS);

+ PrepareForBailoutForId(stmt->OsrEntryId(), BailoutState::NO_REGISTERS);

}

void FullCodeGenerator::EmitProfilingCounterHandlingForReturnSequence(

@@ -680,7 +684,7 @@ void FullCodeGenerator::PrepareForBailoutBeforeSplit(Expression* expr,

Label skip;

if (should_normalize) __ jmp(&skip, Label::kNear);

- PrepareForBailout(expr, TOS_REG);

+ PrepareForBailout(expr, BailoutState::TOS_REGISTER);

if (should_normalize) {

__ cmp(eax, isolate()->factory()->true_value());

Split(equal, if_true, if_false, NULL);

@@ -736,7 +740,7 @@ void FullCodeGenerator::VisitVariableDeclaration(

__ mov(ContextOperand(esi, variable->index()),

Immediate(isolate()->factory()->the_hole_value()));

// No write barrier since the hole value is in old space.

- PrepareForBailoutForId(proxy->id(), NO_REGISTERS);

+ PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS);

}

break;

@@ -757,7 +761,7 @@ void FullCodeGenerator::VisitVariableDeclaration(

__ push(

Immediate(Smi::FromInt(variable->DeclarationPropertyAttributes())));

__ CallRuntime(Runtime::kDeclareLookupSlot);

- PrepareForBailoutForId(proxy->id(), NO_REGISTERS);

+ PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS);

break;

}

@@ -801,7 +805,7 @@ void FullCodeGenerator::VisitFunctionDeclaration(

kDontSaveFPRegs,

EMIT_REMEMBERED_SET,

OMIT_SMI_CHECK);

- PrepareForBailoutForId(proxy->id(), NO_REGISTERS);

+ PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS);

break;

}

@@ -811,7 +815,7 @@ void FullCodeGenerator::VisitFunctionDeclaration(

VisitForStackValue(declaration->fun());

PushOperand(Smi::FromInt(variable->DeclarationPropertyAttributes()));

CallRuntimeWithOperands(Runtime::kDeclareLookupSlot);

- PrepareForBailoutForId(proxy->id(), NO_REGISTERS);

+ PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS);

break;

}

@@ -842,7 +846,7 @@ void FullCodeGenerator::VisitSwitchStatement(SwitchStatement* stmt) {

// Keep the switch value on the stack until a case matches.

VisitForStackValue(stmt->tag());

- PrepareForBailoutForId(stmt->EntryId(), NO_REGISTERS);

+ PrepareForBailoutForId(stmt->EntryId(), BailoutState::NO_REGISTERS);

ZoneList<CaseClause*>* clauses = stmt->cases();

CaseClause* default_clause = NULL; // Can occur anywhere in the list.

@@ -891,7 +895,7 @@ void FullCodeGenerator::VisitSwitchStatement(SwitchStatement* stmt) {

Label skip;

__ jmp(&skip, Label::kNear);

- PrepareForBailout(clause, TOS_REG);

+ PrepareForBailout(clause, BailoutState::TOS_REGISTER);

__ cmp(eax, isolate()->factory()->true_value());

__ j(not_equal, &next_test);

__ Drop(1);

@@ -919,12 +923,12 @@ void FullCodeGenerator::VisitSwitchStatement(SwitchStatement* stmt) {

Comment cmnt(masm_, "[ Case body");

CaseClause* clause = clauses->at(i);

__ bind(clause->body_target());

- PrepareForBailoutForId(clause->EntryId(), NO_REGISTERS);

+ PrepareForBailoutForId(clause->EntryId(), BailoutState::NO_REGISTERS);

VisitStatements(clause->statements());

}

__ bind(nested_statement.break_label());

- PrepareForBailoutForId(stmt->ExitId(), NO_REGISTERS);

+ PrepareForBailoutForId(stmt->ExitId(), BailoutState::NO_REGISTERS);

}

@@ -957,7 +961,7 @@ void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {

ToObjectStub stub(isolate());

__ CallStub(&stub);

__ bind(&done_convert);

- PrepareForBailoutForId(stmt->ToObjectId(), TOS_REG);

+ PrepareForBailoutForId(stmt->ToObjectId(), BailoutState::TOS_REGISTER);

__ push(eax);

// Check cache validity in generated code. If we cannot guarantee cache

@@ -974,7 +978,7 @@ void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {

__ bind(&call_runtime);

__ push(eax);

__ CallRuntime(Runtime::kForInEnumerate);

- PrepareForBailoutForId(stmt->EnumId(), TOS_REG);

+ PrepareForBailoutForId(stmt->EnumId(), BailoutState::TOS_REGISTER);

__ cmp(FieldOperand(eax, HeapObject::kMapOffset),

isolate()->factory()->meta_map());

__ j(not_equal, &fixed_array);

@@ -1010,7 +1014,7 @@ void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {

__ push(eax); // Array

__ mov(eax, FieldOperand(eax, FixedArray::kLengthOffset));

__ push(eax); // Fixed array length (as smi).

- PrepareForBailoutForId(stmt->PrepareId(), NO_REGISTERS);

+ PrepareForBailoutForId(stmt->PrepareId(), BailoutState::NO_REGISTERS);

__ push(Immediate(Smi::FromInt(0))); // Initial index.

// Generate code for doing the condition check.

@@ -1048,7 +1052,7 @@ void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {

__ push(ecx); // Enumerable.

__ push(ebx); // Current entry.

__ CallRuntime(Runtime::kForInFilter);

- PrepareForBailoutForId(stmt->FilterId(), TOS_REG);

+ PrepareForBailoutForId(stmt->FilterId(), BailoutState::TOS_REGISTER);

__ cmp(eax, isolate()->factory()->undefined_value());

__ j(equal, loop_statement.continue_label());

__ mov(ebx, eax);

@@ -1060,11 +1064,11 @@ void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {

// Perform the assignment as if via '='.

{ EffectContext context(this);

EmitAssignment(stmt->each(), stmt->EachFeedbackSlot());

- PrepareForBailoutForId(stmt->AssignmentId(), NO_REGISTERS);

+ PrepareForBailoutForId(stmt->AssignmentId(), BailoutState::NO_REGISTERS);

}

// Both Crankshaft and Turbofan expect BodyId to be right before stmt->body().

- PrepareForBailoutForId(stmt->BodyId(), NO_REGISTERS);

+ PrepareForBailoutForId(stmt->BodyId(), BailoutState::NO_REGISTERS);

// Generate code for the body of the loop.

Visit(stmt->body());

@@ -1081,7 +1085,7 @@ void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {

DropOperands(5);

// Exit and decrement the loop depth.

- PrepareForBailoutForId(stmt->ExitId(), NO_REGISTERS);

+ PrepareForBailoutForId(stmt->ExitId(), BailoutState::NO_REGISTERS);

__ bind(&exit);

decrement_loop_depth();

}

@@ -1239,7 +1243,7 @@ void FullCodeGenerator::EmitGlobalVariableLoad(VariableProxy* proxy,

void FullCodeGenerator::EmitVariableLoad(VariableProxy* proxy,

TypeofMode typeof_mode) {

SetExpressionPosition(proxy);

- PrepareForBailoutForId(proxy->BeforeId(), NO_REGISTERS);

+ PrepareForBailoutForId(proxy->BeforeId(), BailoutState::NO_REGISTERS);

Variable* var = proxy->var();

// Three cases: global variables, lookup variables, and all other types of

@@ -1351,7 +1355,7 @@ void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {

__ CallStub(&stub);

RestoreContext();

}

- PrepareForBailoutForId(expr->CreateLiteralId(), TOS_REG);

+ PrepareForBailoutForId(expr->CreateLiteralId(), BailoutState::TOS_REGISTER);

// If result_saved is true the result is on top of the stack. If

// result_saved is false the result is in eax.

@@ -1387,7 +1391,7 @@ void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {

__ mov(StoreDescriptor::ReceiverRegister(), Operand(esp, 0));

EmitLoadStoreICSlot(property->GetSlot(0));

CallStoreIC();

- PrepareForBailoutForId(key->id(), NO_REGISTERS);

+ PrepareForBailoutForId(key->id(), BailoutState::NO_REGISTERS);

if (NeedsHomeObject(value)) {

EmitSetHomeObjectAccumulator(value, 0, property->GetSlot(1));

}

@@ -1415,7 +1419,7 @@ void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {

DCHECK(property->emit_store());

CallRuntimeWithOperands(Runtime::kInternalSetPrototype);

PrepareForBailoutForId(expr->GetIdForPropertySet(property_index),

- NO_REGISTERS);

+ BailoutState::NO_REGISTERS);

break;

case ObjectLiteral::Property::GETTER:

if (property->emit_store()) {

@@ -1471,7 +1475,7 @@ void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {

DCHECK(property->emit_store());

CallRuntimeWithOperands(Runtime::kInternalSetPrototype);

PrepareForBailoutForId(expr->GetIdForPropertySet(property_index),

- NO_REGISTERS);

+ BailoutState::NO_REGISTERS);

} else {

EmitPropertyKey(property, expr->GetIdForPropertyName(property_index));

VisitForStackValue(value);

@@ -1544,7 +1548,7 @@ void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) {

FastCloneShallowArrayStub stub(isolate(), allocation_site_mode);

__ CallStub(&stub);

}

- PrepareForBailoutForId(expr->CreateLiteralId(), TOS_REG);

+ PrepareForBailoutForId(expr->CreateLiteralId(), BailoutState::TOS_REGISTER);

bool result_saved = false; // Is the result saved to the stack?

ZoneList<Expression*>* subexprs = expr->values();

@@ -1574,7 +1578,8 @@ void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) {

Handle<Code> ic =

CodeFactory::KeyedStoreIC(isolate(), language_mode()).code();

CallIC(ic);

- PrepareForBailoutForId(expr->GetIdForElement(array_index), NO_REGISTERS);

+ PrepareForBailoutForId(expr->GetIdForElement(array_index),

+ BailoutState::NO_REGISTERS);

}

// In case the array literal contains spread expressions it has two parts. The

@@ -1594,7 +1599,8 @@ void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) {

VisitForStackValue(subexpr);

CallRuntimeWithOperands(Runtime::kAppendElement);

- PrepareForBailoutForId(expr->GetIdForElement(array_index), NO_REGISTERS);

+ PrepareForBailoutForId(expr->GetIdForElement(array_index),

+ BailoutState::NO_REGISTERS);

}

if (result_saved) {

@@ -1673,23 +1679,27 @@ void FullCodeGenerator::VisitAssignment(Assignment* expr) {

switch (assign_type) {

case VARIABLE:

EmitVariableLoad(expr->target()->AsVariableProxy());

- PrepareForBailout(expr->target(), TOS_REG);

+ PrepareForBailout(expr->target(), BailoutState::TOS_REGISTER);

break;

case NAMED_SUPER_PROPERTY:

EmitNamedSuperPropertyLoad(property);

- PrepareForBailoutForId(property->LoadId(), TOS_REG);

+ PrepareForBailoutForId(property->LoadId(),

+ BailoutState::TOS_REGISTER);

break;

case NAMED_PROPERTY:

EmitNamedPropertyLoad(property);

- PrepareForBailoutForId(property->LoadId(), TOS_REG);

+ PrepareForBailoutForId(property->LoadId(),

+ BailoutState::TOS_REGISTER);

break;

case KEYED_SUPER_PROPERTY:

EmitKeyedSuperPropertyLoad(property);

- PrepareForBailoutForId(property->LoadId(), TOS_REG);

+ PrepareForBailoutForId(property->LoadId(),

+ BailoutState::TOS_REGISTER);

break;

case KEYED_PROPERTY:

EmitKeyedPropertyLoad(property);

- PrepareForBailoutForId(property->LoadId(), TOS_REG);

+ PrepareForBailoutForId(property->LoadId(),

+ BailoutState::TOS_REGISTER);

break;

}

@@ -1708,7 +1718,7 @@ void FullCodeGenerator::VisitAssignment(Assignment* expr) {

}

// Deoptimization point in case the binary operation may have side effects.

- PrepareForBailout(expr->binary_operation(), TOS_REG);

+ PrepareForBailout(expr->binary_operation(), BailoutState::TOS_REGISTER);

} else {

VisitForAccumulatorValue(expr->value());

}

@@ -1720,7 +1730,7 @@ void FullCodeGenerator::VisitAssignment(Assignment* expr) {

case VARIABLE:

EmitVariableAssignment(expr->target()->AsVariableProxy()->var(),

expr->op(), expr->AssignmentSlot());

- PrepareForBailoutForId(expr->AssignmentId(), TOS_REG);

+ PrepareForBailoutForId(expr->AssignmentId(), BailoutState::TOS_REGISTER);

context()->Plug(eax);

break;

case NAMED_PROPERTY:

@@ -2179,7 +2189,7 @@ void FullCodeGenerator::EmitNamedPropertyAssignment(Assignment* expr) {

PopOperand(StoreDescriptor::ReceiverRegister());

EmitLoadStoreICSlot(expr->AssignmentSlot());

CallStoreIC();

- PrepareForBailoutForId(expr->AssignmentId(), TOS_REG);

+ PrepareForBailoutForId(expr->AssignmentId(), BailoutState::TOS_REGISTER);

context()->Plug(eax);

}

@@ -2225,7 +2235,7 @@ void FullCodeGenerator::EmitKeyedPropertyAssignment(Assignment* expr) {

CodeFactory::KeyedStoreIC(isolate(), language_mode()).code();

EmitLoadStoreICSlot(expr->AssignmentSlot());

CallIC(ic);

- PrepareForBailoutForId(expr->AssignmentId(), TOS_REG);

+ PrepareForBailoutForId(expr->AssignmentId(), BailoutState::TOS_REGISTER);

context()->Plug(eax);

}

@@ -2246,7 +2256,7 @@ void FullCodeGenerator::EmitCallWithLoadIC(Call* expr) {

if (callee->IsVariableProxy()) {

{ StackValueContext context(this);

EmitVariableLoad(callee->AsVariableProxy());

- PrepareForBailout(callee, NO_REGISTERS);

+ PrepareForBailout(callee, BailoutState::NO_REGISTERS);

}

// Push undefined as receiver. This is patched in the method prologue if it

// is a sloppy mode method.

@@ -2258,7 +2268,8 @@ void FullCodeGenerator::EmitCallWithLoadIC(Call* expr) {

DCHECK(!callee->AsProperty()->IsSuperAccess());

__ mov(LoadDescriptor::ReceiverRegister(), Operand(esp, 0));

EmitNamedPropertyLoad(callee->AsProperty());

- PrepareForBailoutForId(callee->AsProperty()->LoadId(), TOS_REG);

+ PrepareForBailoutForId(callee->AsProperty()->LoadId(),

+ BailoutState::TOS_REGISTER);

// Push the target function under the receiver.

PushOperand(Operand(esp, 0));

__ mov(Operand(esp, kPointerSize), eax);

@@ -2293,7 +2304,7 @@ void FullCodeGenerator::EmitSuperCallWithLoadIC(Call* expr) {

// - home_object

// - key

CallRuntimeWithOperands(Runtime::kLoadFromSuper);

- PrepareForBailoutForId(prop->LoadId(), TOS_REG);

+ PrepareForBailoutForId(prop->LoadId(), BailoutState::TOS_REGISTER);

// Replace home_object with target function.

__ mov(Operand(esp, kPointerSize), eax);

@@ -2318,7 +2329,8 @@ void FullCodeGenerator::EmitKeyedCallWithLoadIC(Call* expr,

__ mov(LoadDescriptor::ReceiverRegister(), Operand(esp, 0));

__ mov(LoadDescriptor::NameRegister(), eax);

EmitKeyedPropertyLoad(callee->AsProperty());

- PrepareForBailoutForId(callee->AsProperty()->LoadId(), TOS_REG);

+ PrepareForBailoutForId(callee->AsProperty()->LoadId(),

+ BailoutState::TOS_REGISTER);

// Push the target function under the receiver.

PushOperand(Operand(esp, 0));

@@ -2350,7 +2362,7 @@ void FullCodeGenerator::EmitKeyedSuperCallWithLoadIC(Call* expr) {

// - home_object

// - key

CallRuntimeWithOperands(Runtime::kLoadKeyedFromSuper);

- PrepareForBailoutForId(prop->LoadId(), TOS_REG);

+ PrepareForBailoutForId(prop->LoadId(), BailoutState::TOS_REGISTER);

// Replace home_object with target function.

__ mov(Operand(esp, kPointerSize), eax);

@@ -2370,7 +2382,7 @@ void FullCodeGenerator::EmitCall(Call* expr, ConvertReceiverMode mode) {

VisitForStackValue(args->at(i));

}

- PrepareForBailoutForId(expr->CallId(), NO_REGISTERS);

+ PrepareForBailoutForId(expr->CallId(), BailoutState::NO_REGISTERS);

SetCallPosition(expr, expr->tail_call_mode());

if (expr->tail_call_mode() == TailCallMode::kAllow) {

if (FLAG_trace) {

@@ -2438,7 +2450,7 @@ void FullCodeGenerator::PushCalleeAndWithBaseObject(Call* expr) {

__ CallRuntime(Runtime::kLoadLookupSlotForCall);

PushOperand(eax); // Function.

PushOperand(edx); // Receiver.

- PrepareForBailoutForId(expr->LookupId(), NO_REGISTERS);

+ PrepareForBailoutForId(expr->LookupId(), BailoutState::NO_REGISTERS);

// If fast case code has been generated, emit code to push the function

// and receiver and have the slow path jump around this code.

@@ -2483,7 +2495,7 @@ void FullCodeGenerator::EmitPossiblyEvalCall(Call* expr) {

// Touch up the stack with the resolved function.

__ mov(Operand(esp, (arg_count + 1) * kPointerSize), eax);

- PrepareForBailoutForId(expr->EvalId(), NO_REGISTERS);

+ PrepareForBailoutForId(expr->EvalId(), BailoutState::NO_REGISTERS);

SetCallPosition(expr);

__ mov(edi, Operand(esp, (arg_count + 1) * kPointerSize));

@@ -2532,7 +2544,7 @@ void FullCodeGenerator::VisitCallNew(CallNew* expr) {

CallConstructStub stub(isolate());

__ call(stub.GetCode(), RelocInfo::CODE_TARGET);

OperandStackDepthDecrement(arg_count + 1);

- PrepareForBailoutForId(expr->ReturnId(), TOS_REG);

+ PrepareForBailoutForId(expr->ReturnId(), BailoutState::TOS_REGISTER);

RestoreContext();

context()->Plug(eax);

}

@@ -2967,7 +2979,7 @@ void FullCodeGenerator::EmitCall(CallRuntime* expr) {

for (Expression* const arg : *args) {

VisitForStackValue(arg);

}

- PrepareForBailoutForId(expr->CallId(), NO_REGISTERS);

+ PrepareForBailoutForId(expr->CallId(), BailoutState::NO_REGISTERS);

// Move target to edi.

int const argc = args->length() - 2;

__ mov(edi, Operand(esp, (argc + 1) * kPointerSize));

@@ -3181,7 +3193,8 @@ void FullCodeGenerator::VisitUnaryOperation(UnaryOperation* expr) {

&materialize_true);

if (!context()->IsAccumulatorValue()) OperandStackDepthIncrement(1);

__ bind(&materialize_true);

- PrepareForBailoutForId(expr->MaterializeTrueId(), NO_REGISTERS);

+ PrepareForBailoutForId(expr->MaterializeTrueId(),

+ BailoutState::NO_REGISTERS);

if (context()->IsAccumulatorValue()) {

__ mov(eax, isolate()->factory()->true_value());

} else {

@@ -3189,7 +3202,8 @@ void FullCodeGenerator::VisitUnaryOperation(UnaryOperation* expr) {

}

__ jmp(&done, Label::kNear);

__ bind(&materialize_false);

- PrepareForBailoutForId(expr->MaterializeFalseId(), NO_REGISTERS);

+ PrepareForBailoutForId(expr->MaterializeFalseId(),

+ BailoutState::NO_REGISTERS);

if (context()->IsAccumulatorValue()) {

__ mov(eax, isolate()->factory()->false_value());

} else {

@@ -3288,9 +3302,9 @@ void FullCodeGenerator::VisitCountOperation(CountOperation* expr) {

// We need a second deoptimization point after loading the value

// in case evaluating the property load my have a side effect.

if (assign_type == VARIABLE) {

- PrepareForBailout(expr->expression(), TOS_REG);

+ PrepareForBailout(expr->expression(), BailoutState::TOS_REGISTER);

} else {

- PrepareForBailoutForId(prop->LoadId(), TOS_REG);

+ PrepareForBailoutForId(prop->LoadId(), BailoutState::TOS_REGISTER);

}

// Inline smi case if we are in a loop.

@@ -3345,7 +3359,7 @@ void FullCodeGenerator::VisitCountOperation(CountOperation* expr) {

// Convert old value into a number.

ToNumberStub convert_stub(isolate());

__ CallStub(&convert_stub);

- PrepareForBailoutForId(expr->ToNumberId(), TOS_REG);

+ PrepareForBailoutForId(expr->ToNumberId(), BailoutState::TOS_REGISTER);

// Save result for postfix expressions.

if (expr->is_postfix()) {

@@ -3393,7 +3407,8 @@ void FullCodeGenerator::VisitCountOperation(CountOperation* expr) {

{ EffectContext context(this);

EmitVariableAssignment(expr->expression()->AsVariableProxy()->var(),

Token::ASSIGN, expr->CountSlot());

- PrepareForBailoutForId(expr->AssignmentId(), TOS_REG);

+ PrepareForBailoutForId(expr->AssignmentId(),

+ BailoutState::TOS_REGISTER);

context.Plug(eax);

}

// For all contexts except EffectContext We have the result on

@@ -3405,7 +3420,8 @@ void FullCodeGenerator::VisitCountOperation(CountOperation* expr) {

// Perform the assignment as if via '='.

EmitVariableAssignment(expr->expression()->AsVariableProxy()->var(),

Token::ASSIGN, expr->CountSlot());

- PrepareForBailoutForId(expr->AssignmentId(), TOS_REG);

+ PrepareForBailoutForId(expr->AssignmentId(),

+ BailoutState::TOS_REGISTER);

context()->Plug(eax);

}

break;

@@ -3415,7 +3431,7 @@ void FullCodeGenerator::VisitCountOperation(CountOperation* expr) {

PopOperand(StoreDescriptor::ReceiverRegister());

EmitLoadStoreICSlot(expr->CountSlot());

CallStoreIC();

- PrepareForBailoutForId(expr->AssignmentId(), TOS_REG);

+ PrepareForBailoutForId(expr->AssignmentId(), BailoutState::TOS_REGISTER);

if (expr->is_postfix()) {

if (!context()->IsEffect()) {

context()->PlugTOS();

@@ -3454,7 +3470,7 @@ void FullCodeGenerator::VisitCountOperation(CountOperation* expr) {

CodeFactory::KeyedStoreIC(isolate(), language_mode()).code();

EmitLoadStoreICSlot(expr->CountSlot());

CallIC(ic);

- PrepareForBailoutForId(expr->AssignmentId(), TOS_REG);

+ PrepareForBailoutForId(expr->AssignmentId(), BailoutState::TOS_REGISTER);

if (expr->is_postfix()) {

// Result is on the stack

if (!context()->IsEffect()) {

« no previous file with comments | « src/full-codegen/full-codegen.cc ('k') | src/full-codegen/mips/full-codegen-mips.cc » ('j') | no next file with comments »