Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1969403008: Fix background color for incognito tabs when material design is enabled (Closed)

Created:
4 years, 7 months ago by May
Modified:
4 years, 7 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, mcwilliams+watch_chromium.org, dgn+watch_chromium.org, mcwilliams
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix background color for incognito tabs when material design is enabled BUG=609112 Committed: https://crrev.com/4b9de767b07897905058dad8f5f9c4651c186d26 Cr-Commit-Position: refs/heads/master@{#393552}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Messages

Total messages: 10 (4 generated)
May
4 years, 7 months ago (2016-05-13 15:09:23 UTC) #2
Bernhard Bauer
LGTM +Nicole FYI https://codereview.chromium.org/1969403008/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/NtpColorUtils.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/NtpColorUtils.java (right): https://codereview.chromium.org/1969403008/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/NtpColorUtils.java#newcode26 chrome/android/java/src/org/chromium/chrome/browser/ntp/NtpColorUtils.java:26: return (ChromeFeatureList.isEnabled(ChromeFeatureList.NTP_SNIPPETS) It might almost be ...
4 years, 7 months ago (2016-05-13 15:27:45 UTC) #3
May
https://codereview.chromium.org/1969403008/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/NtpColorUtils.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/NtpColorUtils.java (right): https://codereview.chromium.org/1969403008/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/NtpColorUtils.java#newcode26 chrome/android/java/src/org/chromium/chrome/browser/ntp/NtpColorUtils.java:26: return (ChromeFeatureList.isEnabled(ChromeFeatureList.NTP_SNIPPETS) On 2016/05/13 15:27:45, Bernhard Bauer wrote: > ...
4 years, 7 months ago (2016-05-13 15:38:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969403008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969403008/20001
4 years, 7 months ago (2016-05-13 16:01:46 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-13 16:52:35 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 16:54:10 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4b9de767b07897905058dad8f5f9c4651c186d26
Cr-Commit-Position: refs/heads/master@{#393552}

Powered by Google App Engine
This is Rietveld 408576698