third_party/WebKit/Source/modules/fetch/FetchResponseDataTest.cpp - Issue 1969403004: Expose and check origin of request in response for foreign fetch.

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchResponseDataTest.cpp

Issue 1969403004: Expose and check origin of request in response for foreign fetch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@set-request-and-credentials-mode

Patch Set: update layouttests Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.h » ('j') | third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/FetchResponseDataTest.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/FetchResponseDataTest.cpp b/third_party/WebKit/Source/modules/fetch/FetchResponseDataTest.cpp

index 9bb05cb9a44dba8806114cf43272deb3f89a2f34..78e998defa4cfd0f2b75d3f05160ad61e8c875ce 100644

--- a/third_party/WebKit/Source/modules/fetch/FetchResponseDataTest.cpp

+++ b/third_party/WebKit/Source/modules/fetch/FetchResponseDataTest.cpp

@@ -68,6 +68,8 @@ TEST_F(FetchResponseDataTest, BasicFilter)

FetchResponseData* internalResponse = createInternalResponse();

FetchResponseData* basicResponseData = internalResponse->createBasicFilteredResponse();

+ EXPECT_EQ(internalResponse, basicResponseData->internalResponse());

EXPECT_FALSE(basicResponseData->headerList()->has("set-cookie"));

Vector<String> barValues;

@@ -97,6 +99,8 @@ TEST_F(FetchResponseDataTest, CORSFilter)

FetchResponseData* internalResponse = createInternalResponse();

FetchResponseData* corsResponseData = internalResponse->createCORSFilteredResponse();

+ EXPECT_EQ(internalResponse, corsResponseData->internalResponse());

EXPECT_FALSE(corsResponseData->headerList()->has("set-cookie"));

EXPECT_FALSE(corsResponseData->headerList()->has("bar"));

@@ -114,6 +118,8 @@ TEST_F(FetchResponseDataTest, CORSFilterOnResponseWithAccessControlExposeHeaders

FetchResponseData* corsResponseData = internalResponse->createCORSFilteredResponse();

+ EXPECT_EQ(internalResponse, corsResponseData->internalResponse());

EXPECT_FALSE(corsResponseData->headerList()->has("set-cookie"));

Vector<String> barValues;

@@ -138,6 +144,8 @@ TEST_F(FetchResponseDataTest, OpaqueFilter)

FetchResponseData* internalResponse = createInternalResponse();

FetchResponseData* opaqueResponseData = internalResponse->createOpaqueFilteredResponse();

+ EXPECT_EQ(internalResponse, opaqueResponseData->internalResponse());

EXPECT_FALSE(opaqueResponseData->headerList()->has("set-cookie"));

EXPECT_FALSE(opaqueResponseData->headerList()->has("bar"));

EXPECT_FALSE(opaqueResponseData->headerList()->has("cache-control"));

@@ -148,6 +156,8 @@ TEST_F(FetchResponseDataTest, OpaqueRedirectFilter)

FetchResponseData* internalResponse = createInternalResponse();

FetchResponseData* opaqueResponseData = internalResponse->createOpaqueRedirectFilteredResponse();

+ EXPECT_EQ(internalResponse, opaqueResponseData->internalResponse());

EXPECT_EQ(opaqueResponseData->headerList()->size(), 0u);

EXPECT_EQ(opaqueResponseData->url(), internalResponse->url());

}

@@ -159,6 +169,8 @@ TEST_F(FetchResponseDataTest, OpaqueFilterOnResponseWithAccessControlExposeHeade

FetchResponseData* opaqueResponseData = internalResponse->createOpaqueFilteredResponse();

+ EXPECT_EQ(internalResponse, opaqueResponseData->internalResponse());

EXPECT_FALSE(opaqueResponseData->headerList()->has("set-cookie"));

EXPECT_FALSE(opaqueResponseData->headerList()->has("bar"));

EXPECT_FALSE(opaqueResponseData->headerList()->has("cache-control"));