Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1969383002: Change the maximum account chooser height to 3.5 rows on Mac. (Closed)

Created:
4 years, 7 months ago by vasilii
Modified:
4 years, 7 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the maximum account chooser height to 3.5 rows on Mac. BUG=610277 Committed: https://crrev.com/aa5adc3ce6729f5740936d6b2a2d8fc119c680ac Cr-Commit-Position: refs/heads/master@{#393227}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm View 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
vasilii
Hi Vaclav, please review. The screenshot is in the bug.
4 years, 7 months ago (2016-05-12 09:24:08 UTC) #2
vabr (Chromium)
LGTM!
4 years, 7 months ago (2016-05-12 09:49:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969383002/1
4 years, 7 months ago (2016-05-12 11:31:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 11:33:47 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 11:35:20 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/aa5adc3ce6729f5740936d6b2a2d8fc119c680ac
Cr-Commit-Position: refs/heads/master@{#393227}

Powered by Google App Engine
This is Rietveld 408576698