Source/core/html/forms/InputType.cpp - Issue 196933006: Do not dispatch 'change' events during pressing spin buttons for input[type=number].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/InputType.cpp

Issue 196933006: Do not dispatch 'change' events during pressing spin buttons for input[type=number]. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Avoid extra change event Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp ('K') | « Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp ('k') | Source/core/html/forms/NumberInputType.h » ('j') | Source/core/html/forms/TextFieldInputType.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/forms/InputType.cpp

diff --git a/Source/core/html/forms/InputType.cpp b/Source/core/html/forms/InputType.cpp

index 58dfc0937cc929863ea4287598e2c784e1688dda..c5dc5e28e113181419501df86676fd16c85ff2b3 100644

--- a/Source/core/html/forms/InputType.cpp

+++ b/Source/core/html/forms/InputType.cpp

@@ -934,10 +934,10 @@ void InputType::stepUpFromRenderer(int n)

setValueAsDecimal(current, DispatchNoEvent, IGNORE_EXCEPTION);

}

if ((sign > 0 && current < stepRange.minimum()) || (sign < 0 && current > stepRange.maximum())) {

- setValueAsDecimal(sign > 0 ? stepRange.minimum() : stepRange.maximum(), DispatchInputAndChangeEvent, IGNORE_EXCEPTION);

+ setValueAsDecimal(sign > 0 ? stepRange.minimum() : stepRange.maximum(), DispatchChangeEvent, IGNORE_EXCEPTION);

return;

}

- applyStep(current, n, AnyIsDefaultStep, DispatchInputAndChangeEvent, IGNORE_EXCEPTION);

+ applyStep(current, n, AnyIsDefaultStep, DispatchChangeEvent, IGNORE_EXCEPTION);

}

void InputType::countUsageIfVisible(UseCounter::Feature feature) const