Chromium Code Reviews Chromium Code Reviews
Issue 196933006:
Do not dispatch 'change' events during pressing spin buttons for input[type=number]. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/fast/forms/number/number-spinbutton-changeevent-trigger.html |
| diff --git a/LayoutTests/fast/forms/number/number-spinbutton-changeevent-trigger.html b/LayoutTests/fast/forms/number/number-spinbutton-changeevent-trigger.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..1a35399cd21244a0c1c82e2783a80896041a927e |
| --- /dev/null |
| +++ b/LayoutTests/fast/forms/number/number-spinbutton-changeevent-trigger.html |
| @@ -0,0 +1,57 @@ |
| +<!DOCTYPE> |
| +<html> |
| +<body> |
| +<script src="../../../resources/js-test.js"></script> |
| +<script src="../resources/common.js"></script> |
| +<input type="number" id="num1" onchange="handleChangeEvent(this);" oninput="handleInputEvent(this);"> |
| +<script> |
| +var changeEventCounter = 0; |
| +var inputEventCounter = 0; |
| + |
| +function handleChangeEvent(element) { |
| + ++changeEventCounter; |
| +} |
| + |
| +function handleInputEvent(element) { |
| + ++inputEventCounter; |
| +} |
| + |
| +var numberInput1= document.getElementById('num1'); |
| +numberInput1.focus(); |
| +debug('Should not trigger any event'); |
| +hoverOverElement(numberInput1); |
| +shouldBe('inputEventCounter', '0'); |
| +shouldBe('changeEventCounter', '0'); |
| + |
| +numberInput1.value = 0; |
| +eventSender.mouseMoveTo(numberInput1.offsetLeft + numberInput1.offsetWidth - 10, numberInput1.offsetTop + numberInput1.offsetHeight / 4); |
| +eventSender.mouseDown(); |
| + |
| +debug('Only input event occurs on mouse down'); |
| +shouldBe('inputEventCounter', '1'); |
| +shouldBe('changeEventCounter', '0'); |
| +shouldBe('numberInput1.value', '"1"'); |
|
tkent
2014/03/18 08:26:20
Use shouldBeEqualToString
Habib Virji
2014/03/18 17:37:27
Done.
|
| + |
| +debug('Only change event occurs on mouse up'); |
| +eventSender.mouseUp(); |
| +shouldBe('inputEventCounter', '1'); |
| +shouldBe('changeEventCounter', '1'); |
| +shouldBe('numberInput1.value', '"1"'); |
|
tkent
2014/03/18 08:26:20
shouldBeEqualToString
Habib Virji
2014/03/18 17:37:27
Done.
|
| + |
| +debug('Pressed more than once, still events are triggered'); |
| +eventSender.mouseMoveTo(numberInput1.offsetLeft + numberInput1.offsetWidth - 10, numberInput1.offsetTop + numberInput1.offsetHeight / 4); |
| +eventSender.mouseDown(); |
| +eventSender.mouseUp(); |
| +shouldBe('inputEventCounter', '2'); |
| +shouldBe('changeEventCounter', '2'); |
| +shouldBe('numberInput1.value', '"2"'); |
|
tkent
2014/03/18 08:26:20
shouldBeEqualToString
Habib Virji
2014/03/18 17:37:27
Done.
|
| + |
| +debug('When moving away from field, it should not trigger event, only on value change'); |
| +numberInput1.blur(); |
| +shouldBe('inputEventCounter', '2'); |
| +shouldBe('changeEventCounter', '2'); |
| +shouldBe('numberInput1.value', '"2"'); |
|
tkent
2014/03/18 08:26:20
shouldBeEqualToString
Habib Virji
2014/03/18 17:37:27
Done.
|
| + |
| +</script> |
| +</body> |
| +</html> |
