Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp - Issue 196933006: Do not dispatch 'change' events during pressing spin buttons for input[type=number].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp

Issue 196933006: Do not dispatch 'change' events during pressing spin buttons for input[type=number]. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Test code updated Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp

diff --git a/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp b/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp

index 4db59238bf0e1516fd5de778192d4436e7475102..b1be6db2599347e8fb04120712fc2f6aa1dce33e 100644

--- a/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp

+++ b/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp

@@ -240,6 +240,11 @@ void BaseMultipleFieldsDateAndTimeInputType::spinButtonStepUp()

edit->stepUp();

}

+void BaseMultipleFieldsDateAndTimeInputType::spinButtonDidReleaseMouseCapture()

+ element().dispatchFormControlChangeEvent();

bool BaseMultipleFieldsDateAndTimeInputType::isPickerIndicatorOwnerDisabledOrReadOnly() const

{

return element().isDisabledOrReadOnly();

« no previous file with comments | « Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h ('k') | Source/core/html/forms/InputType.cpp » ('j') | no next file with comments »