Source/core/html/HTMLTextFormControlElement.cpp - Issue 196933006: Do not dispatch 'change' events during pressing spin buttons for input[type=number].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLTextFormControlElement.cpp

Issue 196933006: Do not dispatch 'change' events during pressing spin buttons for input[type=number]. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed setFocus code from ShadowElement to InputElement Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/forms/number/number-spinbutton-changeevent-trigger-expected.txt ('k') | Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h » ('j') | Source/core/html/shadow/SpinButtonElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLTextFormControlElement.cpp

diff --git a/Source/core/html/HTMLTextFormControlElement.cpp b/Source/core/html/HTMLTextFormControlElement.cpp

index 0a0c83fd50aa24ac96ba60d9743a11c469c67610..f389dd44b0668d7b1e07e4fdebf5d9ffd2171f5a 100644

--- a/Source/core/html/HTMLTextFormControlElement.cpp

+++ b/Source/core/html/HTMLTextFormControlElement.cpp

@@ -183,7 +183,7 @@ void HTMLTextFormControlElement::select()

void HTMLTextFormControlElement::dispatchFormControlChangeEvent()

{

- if (m_textAsOfLastFormControlChangeEvent != value()) {

+ if (!equalIgnoringNullity(m_textAsOfLastFormControlChangeEvent, value())) {

dispatchChangeEvent();

setTextAsOfLastFormControlChangeEvent(value());

}