Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: Source/core/html/HTMLTextFormControlElement.cpp

Issue 196933006: Do not dispatch 'change' events during pressing spin buttons for input[type=number]. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Avoid extra change event Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 } 178 }
179 179
180 void HTMLTextFormControlElement::select() 180 void HTMLTextFormControlElement::select()
181 { 181 {
182 setSelectionRange(0, numeric_limits<int>::max(), SelectionHasNoDirection); 182 setSelectionRange(0, numeric_limits<int>::max(), SelectionHasNoDirection);
183 } 183 }
184 184
185 void HTMLTextFormControlElement::dispatchFormControlChangeEvent() 185 void HTMLTextFormControlElement::dispatchFormControlChangeEvent()
186 { 186 {
187 if (m_textAsOfLastFormControlChangeEvent != value()) { 187 if (m_textAsOfLastFormControlChangeEvent != value()) {
188 setTextAsOfLastFormControlChangeEvent(value());
188 dispatchChangeEvent(); 189 dispatchChangeEvent();
189 setTextAsOfLastFormControlChangeEvent(value());
190 } 190 }
191 setChangedSinceLastFormControlChangeEvent(false); 191 setChangedSinceLastFormControlChangeEvent(false);
192 } 192 }
193 193
194 static inline bool hasVisibleTextArea(RenderObject* renderer, HTMLElement* inner Text) 194 static inline bool hasVisibleTextArea(RenderObject* renderer, HTMLElement* inner Text)
195 { 195 {
196 ASSERT(renderer); 196 ASSERT(renderer);
197 return renderer->style()->visibility() != HIDDEN && innerText && innerText-> renderer() && innerText->renderBox()->height(); 197 return renderer->style()->visibility() != HIDDEN && innerText && innerText-> renderer() && innerText->renderBox()->height();
198 } 198 }
199 199
(...skipping 447 matching lines...) Expand 10 before | Expand all | Expand 10 after
647 647
648 return "ltr"; 648 return "ltr";
649 } 649 }
650 650
651 HTMLElement* HTMLTextFormControlElement::innerTextElement() const 651 HTMLElement* HTMLTextFormControlElement::innerTextElement() const
652 { 652 {
653 return toHTMLElement(userAgentShadowRoot()->getElementById(ShadowElementName s::innerEditor())); 653 return toHTMLElement(userAgentShadowRoot()->getElementById(ShadowElementName s::innerEditor()));
654 } 654 }
655 655
656 } // namespace Webcore 656 } // namespace Webcore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698