Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Side by Side Diff: Source/core/html/HTMLTextFormControlElement.cpp

Issue 196933006: Do not dispatch 'change' events during pressing spin buttons for input[type=number]. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Test code updated Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
176 setSelectionRange(selectionStart(), selectionEnd(), direction); 176 setSelectionRange(selectionStart(), selectionEnd(), direction);
177 } 177 }
178 178
179 void HTMLTextFormControlElement::select() 179 void HTMLTextFormControlElement::select()
180 { 180 {
181 setSelectionRange(0, numeric_limits<int>::max(), SelectionHasNoDirection); 181 setSelectionRange(0, numeric_limits<int>::max(), SelectionHasNoDirection);
182 } 182 }
183 183
184 void HTMLTextFormControlElement::dispatchFormControlChangeEvent() 184 void HTMLTextFormControlElement::dispatchFormControlChangeEvent()
185 { 185 {
186 if (m_textAsOfLastFormControlChangeEvent != value()) { 186 if (!equalIgnoringNullity(m_textAsOfLastFormControlChangeEvent, value())) {
187 dispatchChangeEvent(); 187 dispatchChangeEvent();
188 setTextAsOfLastFormControlChangeEvent(value()); 188 setTextAsOfLastFormControlChangeEvent(value());
189 } 189 }
190 setChangedSinceLastFormControlChangeEvent(false); 190 setChangedSinceLastFormControlChangeEvent(false);
191 } 191 }
192 192
193 static inline bool hasVisibleTextArea(RenderObject* renderer, HTMLElement* inner Text) 193 static inline bool hasVisibleTextArea(RenderObject* renderer, HTMLElement* inner Text)
194 { 194 {
195 ASSERT(renderer); 195 ASSERT(renderer);
196 return renderer->style()->visibility() != HIDDEN && innerText && innerText-> renderer() && innerText->renderBox()->height(); 196 return renderer->style()->visibility() != HIDDEN && innerText && innerText-> renderer() && innerText->renderBox()->height();
(...skipping 449 matching lines...) Expand 10 before | Expand all | Expand 10 after
646 646
647 return "ltr"; 647 return "ltr";
648 } 648 }
649 649
650 HTMLElement* HTMLTextFormControlElement::innerTextElement() const 650 HTMLElement* HTMLTextFormControlElement::innerTextElement() const
651 { 651 {
652 return toHTMLElement(userAgentShadowRoot()->getElementById(ShadowElementName s::innerEditor())); 652 return toHTMLElement(userAgentShadowRoot()->getElementById(ShadowElementName s::innerEditor()));
653 } 653 }
654 654
655 } // namespace Webcore 655 } // namespace Webcore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698