Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1969313007: Handle explicit constructor. (Closed)

Created:
4 years, 7 months ago by Johnni Winther
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -13 lines) Patch
M pkg/compiler/lib/src/resolution/constructors.dart View 1 chunk +1 line, -1 line 2 comments Download
M tests/compiler/dart2js/serialization/compilation_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/serialization/helper.dart View 4 chunks +23 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/serialization/model_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_data.dart View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Johnni Winther
4 years, 7 months ago (2016-05-13 13:00:02 UTC) #2
Johnni Winther
PTAL
4 years, 7 months ago (2016-05-17 13:07:43 UTC) #3
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1969313007/diff/1/pkg/compiler/lib/src/resolution/constructors.dart File pkg/compiler/lib/src/resolution/constructors.dart (right): https://codereview.chromium.org/1969313007/diff/1/pkg/compiler/lib/src/resolution/constructors.dart#newcode252 pkg/compiler/lib/src/resolution/constructors.dart:252: ConstructorElement lookedupConstructor, funny that all of the semantic ...
4 years, 7 months ago (2016-05-17 20:42:38 UTC) #4
Johnni Winther
Committed patchset #1 (id:1) manually as f3ff2a630295266753d50e52a40fb06c80f8c800 (presubmit successful).
4 years, 7 months ago (2016-05-18 10:13:27 UTC) #6
Johnni Winther
4 years, 7 months ago (2016-05-18 10:17:21 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1969313007/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/constructors.dart (right):

https://codereview.chromium.org/1969313007/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/constructors.dart:252: ConstructorElement
lookedupConstructor,
On 2016/05/17 20:42:38, Siggi Cherem (dart-lang) wrote:
> funny that all of the semantic changes are just 1 char :)

Yes :)

Powered by Google App Engine
This is Rietveld 408576698