Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 1969313006: Modify dump_inferred_types to use SummaryDataStore. (Closed)

Created:
4 years, 7 months ago by Paul Berry
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Modify dump_inferred_types to use SummaryDataStore. This paves the way for further improvements to dump_inferred_types to allow it to make use of linker data structures. That will in turn make it easier to validate the linker code by exercising more of it. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/a407f6ad37a9abdde395665a0e687eff20dee593

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -62 lines) Patch
M pkg/analyzer/tool/summary/dump_inferred_types.dart View 6 chunks +12 lines, -62 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 7 months ago (2016-05-12 17:26:49 UTC) #2
scheglov
LGTM
4 years, 7 months ago (2016-05-12 17:29:52 UTC) #3
Paul Berry
4 years, 7 months ago (2016-05-12 17:35:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a407f6ad37a9abdde395665a0e687eff20dee593 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698