[headless] Embed pak file into binary.

ui/base/resource/resource_bundle.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_BASE_RESOURCE_RESOURCE_BUNDLE_H_
 #define UI_BASE_RESOURCE_RESOURCE_BUNDLE_H_
 
 #include <stddef.h>
 
 #include <map>
@@ skipping 124 matching lines @@
   // MemoryMappedFile::Region::kWholeFile, the entire |pak_file| is used.
   // This allows the use of this function in a sandbox without local file
   // access (as on Android).
   static void InitSharedInstanceWithPakFileRegion(
       base::File pak_file,
       const base::MemoryMappedFile::Region& region);
 
   // Initialize the ResourceBundle using given data pack path for testing.
   static void InitSharedInstanceWithPakPath(const base::FilePath& path);
 
+  // Initialize the ResourceBundle using data pack from given buffer.

[sky, 2016/05/19 20:25:54]

Also document lifetime here.

[altimin, 2016/05/19 23:04:48]

Done.

+  static void InitSharedInstanceWithPakBuffer(base::StringPiece buffer);

[sky, 2016/05/19 20:25:54]

I dislike exposing functions in the public class that are intended purely for
tests and not marked as such.

As a precursor to this patch move the test setup routines
(InitSharedInstanceWithPakPath and LoadTestResources) into a test only class
that is friended by ResourceBundle.

[altimin, 2016/05/19 23:04:47]

Actually, this is not test-only function. InitSharedInstanceWithPakFileRegion is
used by content shell, and by newly introduced headless shell too.

If you have any ideas how it should be done instead, please let me know.

[sky, 2016/05/20 15:49:04]

Content shell is primarily there for tests, and not a shipping product.
Additionally this sets 'is_test_resources_' to true and calls LoadTestResources.
I still stand by what I've outlined.

+
   // Delete the ResourceBundle for this process if it exists.
   static void CleanupSharedInstance();
 
   // Returns true after the global resource loader instance has been created.
   static bool HasSharedInstance();
 
+  // Initialize the ResourceBundle using data pack from given buffer.
   // Return the global resource loader instance.
   static ResourceBundle& GetSharedInstance();
 
   // Check if the .pak for the given locale exists.
   bool LocaleDataPakExists(const std::string& locale);
 
   // Registers additional data pack files with this ResourceBundle.  When
   // looking for a DataResource, we will search these files after searching the
   // main module. |path| should be the complete path to the pack file if known
   // or just the pack file name otherwise (the delegate may optionally override
@@ skipping 188 matching lines @@
 
   // Try to load the locale specific strings from an external data module.
   // Returns the locale that is loaded.
   std::string LoadLocaleResources(const std::string& pref_locale);
 
   // Load test resources in given paths. If either path is empty an empty
   // resource pack is loaded.
   void LoadTestResources(const base::FilePath& path,
                          const base::FilePath& locale_path);
 
+  // Load test resources from given buffers.
+  void LoadTestResourcesFromBuffer(base::StringPiece data,
+                                   base::StringPiece locale_data);
+
   // Unload the locale specific strings and prepares to load new ones. See
   // comments for ReloadLocaleResources().
   void UnloadLocaleResources();
 
   // Initializes the font description of default gfx::FontList.
   void InitDefaultFontList();
 
   // Fills the |bitmap| given the data file to look in and the |resource_id|.
   // Returns false if the resource does not exist.
   //
@@ skipping 74 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(ResourceBundle);
 };
 
 }  // namespace ui
 
 // TODO(beng): Someday, maybe, get rid of this.
 using ui::ResourceBundle;
 
 #endif  // UI_BASE_RESOURCE_RESOURCE_BUNDLE_H_