Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1969303002: Upstream WebAPK notification related code (Closed)

Created:
4 years, 7 months ago by pkotwicz
Modified:
4 years, 7 months ago
Reviewers:
Peter Beverloo, Xi Han
CC:
chromium-reviews, mlamouri+watch-notifications_chromium.org, Yaron
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream WebAPK notification related code This CL makes Chrome hand off displaying notifications which fall within the URL scope of a WebAPK to the WebAPK. Doing the hand off enables these notifications to look in the Android UI as if they were dispatched by the WebAPK - not Chrome. BUG=609122 Committed: https://crrev.com/f3267daa0067ce785e944e8f778346a17b3f35c7 Cr-Commit-Position: refs/heads/master@{#395157}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 32

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+667 lines, -31 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java View 1 2 3 4 13 chunks +64 lines, -15 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/notifications/WebApkNotificationClient.java View 1 2 3 4 1 chunk +67 lines, -0 lines 0 comments Download
M chrome/android/java_sources.gni View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/webapk/libs/client/BUILD.gn View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkServiceConnectionManagerTest.java View 1 1 chunk +152 lines, -0 lines 0 comments Download
A chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkServiceConnectionManager.java View 1 chunk +164 lines, -0 lines 0 comments Download
A chrome/android/webapk/libs/runtime_library/BUILD.gn View 1 chunk +19 lines, -0 lines 0 comments Download
A chrome/android/webapk/libs/runtime_library/src/README View 1 chunk +18 lines, -0 lines 0 comments Download
A chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/IWebApkApi.aidl View 1 2 3 4 1 chunk +21 lines, -0 lines 0 comments Download
A chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/WebApkServiceImpl.java View 1 2 3 4 1 chunk +53 lines, -0 lines 0 comments Download
A + chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/common.aidl View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/webapk/shell_apk/AndroidManifest.xml View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/android/webapk/shell_apk/BUILD.gn View 1 2 3 4 1 chunk +5 lines, -1 line 0 comments Download
M chrome/android/webapk/shell_apk/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkServiceFactory.java View 1 2 3 4 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/browser/notifications/notification_platform_bridge_android.h View 2 chunks +16 lines, -5 lines 0 comments Download
M chrome/browser/notifications/notification_platform_bridge_android.cc View 1 2 3 4 8 chunks +42 lines, -9 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (15 generated)
pkotwicz
Xi, can you please take a look? I have excluded all of the security checking ...
4 years, 7 months ago (2016-05-12 04:34:24 UTC) #7
Xi Han
lgtm with nits. https://codereview.chromium.org/1969303002/diff/80001/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java File chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java (left): https://codereview.chromium.org/1969303002/diff/80001/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java#oldcode531 chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java:531: // Temporarily allowing disk access. TODO: ...
4 years, 7 months ago (2016-05-13 13:42:53 UTC) #8
pkotwicz
Note that I will need to add CommandLine checks for whether WebAPKs are enabled to ...
4 years, 7 months ago (2016-05-13 13:43:58 UTC) #9
pkotwicz
Peter Beverloo, can you please take a look at the changes in chrome/android/java/src/org/chromium/chrome/browser/notifications and chrome/browser/notifications
4 years, 7 months ago (2016-05-15 00:36:37 UTC) #12
pkotwicz
Peter Beverloo Ping!
4 years, 7 months ago (2016-05-17 18:01:38 UTC) #13
Peter Beverloo
Apologies for the delay! I will review your CL tomorrow.
4 years, 7 months ago (2016-05-18 21:29:30 UTC) #14
Peter Beverloo
https://codereview.chromium.org/1969303002/diff/160001/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java File chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java (right): https://codereview.chromium.org/1969303002/diff/160001/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java#newcode163 chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java:163: * @return Package name of the WebAPK which should ...
4 years, 7 months ago (2016-05-19 15:59:01 UTC) #15
pkotwicz
Peter Beverloo can you please take another look? https://codereview.chromium.org/1969303002/diff/160001/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java File chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java (right): https://codereview.chromium.org/1969303002/diff/160001/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java#newcode209 chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java:209: } ...
4 years, 7 months ago (2016-05-20 00:45:19 UTC) #18
Peter Beverloo
lgtm In the mid-term, would it be possible to have some sort of instrumentation tests ...
4 years, 7 months ago (2016-05-20 14:12:16 UTC) #19
pkotwicz
I have logged crbug.com/613624 w.r.t to adding WebAPK notification instrumentation tests
4 years, 7 months ago (2016-05-20 18:18:15 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969303002/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969303002/260001
4 years, 7 months ago (2016-05-20 19:31:13 UTC) #24
commit-bot: I haz the power
Committed patchset #6 (id:260001)
4 years, 7 months ago (2016-05-20 20:43:21 UTC) #26
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 20:45:32 UTC) #28
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/f3267daa0067ce785e944e8f778346a17b3f35c7
Cr-Commit-Position: refs/heads/master@{#395157}

Powered by Google App Engine
This is Rietveld 408576698