Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 19693017: Merged r15782 into 3.19 branch. (Closed)

Created:
7 years, 5 months ago by palfia
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Merged r15782 into 3.19 branch. Fix unaligned accesses in back_edge tables. R=jkummerow@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M src/deoptimizer.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M src/full-codegen.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
palfia
7 years, 5 months ago (2013-07-22 19:17:37 UTC) #1
palfia
PTAL.
7 years, 5 months ago (2013-07-22 19:18:08 UTC) #2
Jakob Kummerow
We usually don't back-merge performance improvements, only crash/correctness/security fixes. You'll have to give me a ...
7 years, 5 months ago (2013-07-23 08:01:56 UTC) #3
Paul Lind
This is fixing a small performance regression, which is subtly different than performance improvement. However, ...
7 years, 5 months ago (2013-07-23 18:28:41 UTC) #4
Jakob Kummerow
I don't feel strongly about it either way, but "just about un-measurable" doesn't sound like ...
7 years, 5 months ago (2013-07-23 19:14:05 UTC) #5
Paul Lind
Agreed, thanks for explaining the policy, which I had not fully understood. Ákos, can you ...
7 years, 5 months ago (2013-07-23 19:21:38 UTC) #6
palfia
7 years, 5 months ago (2013-07-23 19:24:21 UTC) #7
Closing issue..

Powered by Google App Engine
This is Rietveld 408576698