Hooking up setBackgroundColor from AwContents to render process

android_webview/browser/renderer_host/aw_render_view_host_ext.cc

Index: android_webview/browser/renderer_host/aw_render_view_host_ext.cc
diff --git a/android_webview/browser/renderer_host/aw_render_view_host_ext.cc b/android_webview/browser/renderer_host/aw_render_view_host_ext.cc
index 46bb312d0105384f30b8c24ed105c682e0f7eb81..707656de4fda872bab779919d254656e1030c5c3 100644
--- a/android_webview/browser/renderer_host/aw_render_view_host_ext.cc
+++ b/android_webview/browser/renderer_host/aw_render_view_host_ext.cc
@@ -25,6 +25,7 @@ AwRenderViewHostExt::AwRenderViewHostExt(
     AwRenderViewHostExtClient* client, content::WebContents* contents)
     : content::WebContentsObserver(contents),
       client_(client),
+      background_color_(SK_ColorWHITE),
       has_new_hit_test_data_(false) {
   DCHECK(client_);
 }
@@ -85,6 +86,19 @@ void AwRenderViewHostExt::SetInitialPageScale(double page_scale_factor) {
                                          page_scale_factor));
 }
 
+void AwRenderViewHostExt::SetBackgroundColor(SkColor c) {

[mkosiba (inactive), 2013/07/23 11:14:40]

why not put it in AwSettings? There's already logic in there to sync the setting
on RenderViewCreated and this code seems to be replicating that.

[joth, 2013/07/23 17:38:59]

I feel AwSettings is the upstream (native) implementation of WebSettings. It's a
peer of AwContents - both handle the JNI boundary.
Internally AwSettings delegates IPC to AwRenderViewHostExt anyway, so delegating
here to AwSettings is just putting another player in the path for no benefit
AFAICT.
Also, the 'sync the settings' code in AwSettings is heavily focused on 'pulling'
values from java to native in a thread safe way. background color doesn't need
any of that (it's pushed from java, and single threaded), so I think it would be
confusing matters to route it via that path.

It an interesting point that AwSettings uses RenderViewCreated rather than
RenderViewReady. RVR seems to work, but the docs say "This method is invoked
when the RenderView of the current RenderViewHost is ready, e.g. because we
recreated it after a crash." which is kind of ambiguous. I think I'll switch to
use RVC to be consistent with AwSettings.

+  if (background_color_ == c)
+    return;
+  background_color_ = c;
+  Send(new AwViewMsg_SetBackgroundColor(web_contents()->GetRoutingID(),
+                                        background_color_));
+}
+
+void AwRenderViewHostExt::RenderViewReady() {
+  Send(new AwViewMsg_SetBackgroundColor(web_contents()->GetRoutingID(),
+                                        background_color_));
+}
+
 void AwRenderViewHostExt::RenderProcessGone(base::TerminationStatus status) {
   DCHECK(CalledOnValidThread());
   for (std::map<int, DocumentHasImagesResult>::iterator pending_req =