Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/compiler.dart

Issue 19693011: Fix some bugs regarding native fields. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Remove debug code and add a comment Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/sdk/lib/_internal/compiler/implementation/compiler.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/compiler.dart b/dart/sdk/lib/_internal/compiler/implementation/compiler.dart
index c3012714409a6e53255047ea012895530e65dac8..47e44e73bf95d64fa429537d0333faa515be4d8d 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/compiler.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/compiler.dart
@@ -680,7 +680,7 @@ abstract class Compiler implements DiagnosticListener {
tracer.close();
totalCompileTime.stop();
}
- return true;
+ return !compilationFailed;
}
bool hasIsolateSupport() => isolateLibrary != null;
@@ -955,6 +955,10 @@ abstract class Compiler implements DiagnosticListener {
backend.assembleProgram();
checkQueues();
+
+ if (compilationFailed) {
+ assembledCode = null; // Signals failure.
+ }
}
void fullyEnqueueLibrary(LibraryElement library, Enqueuer world) {

Powered by Google App Engine
This is Rietveld 408576698