runtime/bin/eventhandler_win.cc - Issue 19693007: Don't call accept the c socket, if we're currently closing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/eventhandler_win.cc

Issue 19693007: Don't call accept the c socket, if we're currently closing. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/eventhandler_win.cc

diff --git a/runtime/bin/eventhandler_win.cc b/runtime/bin/eventhandler_win.cc

index 3ced5d085d93b504fa9a5953e64b2e89b2699355..665d3493dc9b55d991ad74f2914880f02592fc4a 100644

--- a/runtime/bin/eventhandler_win.cc

+++ b/runtime/bin/eventhandler_win.cc

@@ -324,7 +324,7 @@ void FileHandle::EnsureInitialized(EventHandlerImplementation* event_handler) {

bool FileHandle::IsClosed() {

- return IsClosing();

+ return IsClosing() && !HasPendingRead();

kustermann 2013/07/19 16:56:24 Do we need a 'HasPendingWrite()' here as well?

Anders Johnsen 2013/07/19 17:03:39 While I convinced myself that FileHandles never wo

}

« no previous file with comments | « no previous file | runtime/bin/socket_patch.dart » ('j') | no next file with comments »