[debugger] Prevent shared function info duplicates

[debugger] Prevent shared function info duplicates

Clear the list of shared function infos attached to a script before
compiling for live edit in order to avoid duplicates. This was lost in
058deb27132c97c62a99826455abc2bc87fae1b7. Additionally, we restore the
original list of shared function infos once we're done with live edit
work.

R=yangguo@chromium.org
BUG=

Committed: https://crrev.com/792e9c6d168629fdddb3d04a7dfbb9f1ca3b0731
Cr-Commit-Position: refs/heads/master@{#36200}

[jgruber1, 2016-05-12 07:28:04]

The CQ bit was checked by jgruber@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-12 07:28:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1969293003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1969293003/1

[Yang, 2016-05-12 07:43:14]

LGTM with comment.

https://codereview.chromium.org/1969293003/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1969293003/diff/1/src/compiler.cc#newcode1267
src/compiler.cc:1267: DCHECK(!isolate->has_pending_exception());
We could just rephrase this as DCHECK(!compilation_succeeded ||
!isolate->has_pending_exception());

[commit-bot: I haz the power, 2016-05-12 07:47:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 07:47:02]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[jgruber1, 2016-05-12 08:02:59]

The CQ bit was checked by jgruber@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-12 08:03:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1969293003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1969293003/20001

[jgruber1, 2016-05-12 08:26:46]

https://codereview.chromium.org/1969293003/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1969293003/diff/1/src/compiler.cc#newcode1267
src/compiler.cc:1267: DCHECK(!isolate->has_pending_exception());
On 2016/05/12 07:43:14, Yang wrote:
> We could just rephrase this as DCHECK(!compilation_succeeded ||
> !isolate->has_pending_exception());

Rewrote this part to again exit early on compilation failure since we have some
more logic coming up in the successful case.

[commit-bot: I haz the power, 2016-05-12 08:31:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 08:31:44]

Dry run: This issue passed the CQ dry run.

[jgruber1, 2016-05-12 08:38:51]

The CQ bit was checked by jgruber@google.com

[jgruber1, 2016-05-12 08:38:52]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1969293003/#ps20001
(title: "Fix logic & other tweaks")

[commit-bot: I haz the power, 2016-05-12 08:39:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1969293003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1969293003/20001

[commit-bot: I haz the power, 2016-05-12 08:40:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-12 08:40:59]

Description was changed from

==========
[debugger] Prevent shared function info duplicates

Clear the list of shared function infos attached to a script before
compiling for live edit in order to avoid duplicates. This was lost in
058deb27132c97c62a99826455abc2bc87fae1b7. Additionally, we restore the
original list of shared function infos once we're done with live edit
work.

R=yangguo@chromium.org
BUG=
==========

to

==========
[debugger] Prevent shared function info duplicates

Clear the list of shared function infos attached to a script before
compiling for live edit in order to avoid duplicates. This was lost in
058deb27132c97c62a99826455abc2bc87fae1b7. Additionally, we restore the
original list of shared function infos once we're done with live edit
work.

R=yangguo@chromium.org
BUG=

Committed: https://crrev.com/792e9c6d168629fdddb3d04a7dfbb9f1ca3b0731
Cr-Commit-Position: refs/heads/master@{#36200}
==========

[commit-bot: I haz the power, 2016-05-12 08:41:00]

Patchset 2 (id:??) landed as
https://crrev.com/792e9c6d168629fdddb3d04a7dfbb9f1ca3b0731
Cr-Commit-Position: refs/heads/master@{#36200}