Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1087)

Unified Diff: net/cert/x509_util_openssl.cc

Issue 1969293002: Remove net::ParsedCertificate struct. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/internal/verify_certificate_chain.cc ('k') | net/net.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/x509_util_openssl.cc
diff --git a/net/cert/x509_util_openssl.cc b/net/cert/x509_util_openssl.cc
index 9274799f7018c17303833b99728c1a7c985bf5da..2327deddcf29cde90ab173a4e2a4da0a3d74d5d0 100644
--- a/net/cert/x509_util_openssl.cc
+++ b/net/cert/x509_util_openssl.cc
@@ -317,14 +317,16 @@ bool GetTLSServerEndPointChannelBinding(const X509Certificate& certificate,
&der_encoded_certificate))
return false;
- ParsedCertificate parsed_certificate;
- if (!ParseCertificate(der::Input(base::StringPiece(der_encoded_certificate)),
- &parsed_certificate))
+ der::Input tbs_certificate_tlv;
+ der::Input signature_algorithm_tlv;
+ der::BitString signature_value;
+ if (!ParseCertificate(der::Input(&der_encoded_certificate),
+ &tbs_certificate_tlv, &signature_algorithm_tlv,
+ &signature_value))
return false;
std::unique_ptr<SignatureAlgorithm> signature_algorithm =
- SignatureAlgorithm::CreateFromDer(
- parsed_certificate.signature_algorithm_tlv);
+ SignatureAlgorithm::CreateFromDer(signature_algorithm_tlv);
if (!signature_algorithm)
return false;
« no previous file with comments | « net/cert/internal/verify_certificate_chain.cc ('k') | net/net.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698