Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1297)

Unified Diff: net/cert/internal/parse_ocsp_unittest.cc

Issue 1969293002: Remove net::ParsedCertificate struct. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/internal/parse_ocsp.cc ('k') | net/cert/internal/verify_certificate_chain.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/internal/parse_ocsp_unittest.cc
diff --git a/net/cert/internal/parse_ocsp_unittest.cc b/net/cert/internal/parse_ocsp_unittest.cc
index 12657e626952b1fb2b38ef93c0f72a6e06e93d75..3a2c60c73c9f97abbf6e14895f232b2f16937fbb 100644
--- a/net/cert/internal/parse_ocsp_unittest.cc
+++ b/net/cert/internal/parse_ocsp_unittest.cc
@@ -48,11 +48,18 @@ OCSPFailure ParseOCSP(const std::string& file_name) {
der::Input ca_input(&ca_data);
der::Input cert_input(&cert_data);
- ParsedCertificate issuer;
- ParsedCertificate cert;
- if (!ParseCertificate(ca_input, &issuer))
+ der::Input issuer_tbs_certificate_tlv;
+ der::Input issuer_signature_algorithm_tlv;
+ der::BitString issuer_signature_value;
+ der::Input cert_tbs_certificate_tlv;
+ der::Input cert_signature_algorithm_tlv;
+ der::BitString cert_signature_value;
+ if (!ParseCertificate(ca_input, &issuer_tbs_certificate_tlv,
+ &issuer_signature_algorithm_tlv,
+ &issuer_signature_value))
return PARSE_CERT;
- if (!ParseCertificate(cert_input, &cert))
+ if (!ParseCertificate(cert_input, &cert_tbs_certificate_tlv,
+ &cert_signature_algorithm_tlv, &cert_signature_value))
return PARSE_CERT;
OCSPResponse parsed_ocsp;
OCSPResponseData parsed_ocsp_data;
@@ -65,7 +72,8 @@ OCSPFailure ParseOCSP(const std::string& file_name) {
OCSPCertStatus status;
- if (!GetOCSPCertStatus(parsed_ocsp_data, issuer, cert, &status))
+ if (!GetOCSPCertStatus(parsed_ocsp_data, issuer_tbs_certificate_tlv,
+ cert_tbs_certificate_tlv, &status))
return PARSE_OCSP_SINGLE_RESPONSE;
switch (status.status) {
« no previous file with comments | « net/cert/internal/parse_ocsp.cc ('k') | net/cert/internal/verify_certificate_chain.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698