Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 1969263004: sync compositor: Remove begin frame source (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index e565277f72e1ab7423b24f3e0991b367bcd2b92d..8d1e69442b137154c9290453d1667bde4c431523 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -1463,22 +1463,18 @@ void RenderWidgetHostViewAndroid::SendBeginFrame(base::TimeTicks frame_time,
TRACE_EVENT1("cc", "RenderWidgetHostViewAndroid::SendBeginFrame",
"frame_time_us", frame_time.ToInternalValue());
- if (using_browser_compositor_) {
- // TODO(brianderson): Replace this hardcoded deadline after Android
- // switches to Surfaces and the Browser's commit isn't in the critcal path.
- base::TimeTicks deadline = frame_time + (vsync_period * 0.6);
-
- host_->Send(new ViewMsg_BeginFrame(
- host_->GetRoutingID(),
- cc::BeginFrameArgs::Create(BEGINFRAME_FROM_HERE, frame_time, deadline,
- vsync_period, cc::BeginFrameArgs::NORMAL)));
- } else if (sync_compositor_) {
- // The synchronous compositor synchronously does it's work in this call.
- // It does not use a deadline.
- sync_compositor_->BeginFrame(cc::BeginFrameArgs::Create(
- BEGINFRAME_FROM_HERE, frame_time, base::TimeTicks(), vsync_period,
- cc::BeginFrameArgs::NORMAL));
- }
+ // The synchronous compositor synchronously does it's work in this call.
+ // It does not use a deadline.
no sievers 2016/06/03 20:35:50 nit: s/it's/its or rather maybe update the comment
boliu 2016/06/03 21:01:06 rewored
+ // TODO(brianderson): Replace this hardcoded deadline after Android
+ // switches to Surfaces and the Browser's commit isn't in the critcal path.
+ base::TimeTicks deadline =
+ sync_compositor_ ? base::TimeTicks() : frame_time + (vsync_period * 0.6);
+ host_->Send(new ViewMsg_BeginFrame(
+ host_->GetRoutingID(),
+ cc::BeginFrameArgs::Create(BEGINFRAME_FROM_HERE, frame_time, deadline,
+ vsync_period, cc::BeginFrameArgs::NORMAL)));
+ if (sync_compositor_)
+ sync_compositor_->DidSendBeginFrame();
}
bool RenderWidgetHostViewAndroid::Animate(base::TimeTicks frame_time) {

Powered by Google App Engine
This is Rietveld 408576698