sync compositor: Remove begin frame source

sync compositor: Remove begin frame source

Share the same BeginFrameSource implementation with chrome.

The old synchronous begin frame IPC is split into two parts:
an async begin frame IPC (shared with rest of chrome),
and a sync IPC to synchronously retrieve the renderer state.

Note needs_begin_frame is no longer part of the synchronous
state retrieved from renderer. This is ok because input
is already async and that's the only time when having an
up-to-date needs_begin_frame really matters.

This removes the whole synchronous compositor "IsActive"
concept since it's superceded completely by visibility.

BUG=609977
Committed: https://crrev.com/8f3016ee733ac3e4ccd65e0711f5d3a9b92e5e49
Cr-Commit-Position: refs/heads/master@{#397874}

[boliu, 2016-05-13 03:50:33]

Description was changed from

==========
sync compositor: Remove begin frame source

Share the same BeginFrameSource implementation with chrome.

BUG=609977
==========

to

==========
sync compositor: Remove begin frame source

Share the same BeginFrameSource implementation with chrome.

* includes https://codereview.chromium.org/1971023006/
* browser scroll cannot be posted after draw


BUG=609977
==========

[boliu, 2016-05-13 17:21:43]

Description was changed from

==========
sync compositor: Remove begin frame source

Share the same BeginFrameSource implementation with chrome.

* includes https://codereview.chromium.org/1971023006/
* browser scroll cannot be posted after draw


BUG=609977
==========

to

==========
sync compositor: Remove begin frame source

Share the same BeginFrameSource implementation with chrome.

includes and depends on these two CLs
https://codereview.chromium.org/1974683005/
https://codereview.chromium.org/1971023006/

BUG=609977
==========

[boliu, 2016-06-02 15:27:20]

Description was changed from

==========
sync compositor: Remove begin frame source

Share the same BeginFrameSource implementation with chrome.

includes and depends on these two CLs
https://codereview.chromium.org/1974683005/
https://codereview.chromium.org/1971023006/

BUG=609977
==========

to

==========
sync compositor: Remove begin frame source

Share the same BeginFrameSource implementation with chrome.

The old synchronous begin frame IPC is split into two parts:
an async begin frame IPC (shared with rest of chrome),
and a sync IPC to synchronously retrieve the renderer state.

Note needs_begin_frame is no longer part of the synchronous
state retrieved from renderer. This is ok because input
is already async and that's the only time when having an
up-to-date needs_begin_frame really matters.

This removes the whole synchronous compositor "IsActive"
concept since it's superceded completely by visibility.

BUG=609977
==========

[boliu, 2016-06-02 15:27:44]

boliu@chromium.org changed reviewers:
+ sievers@chromium.org

[boliu, 2016-06-02 15:27:44]

ptal

[no sievers, 2016-06-03 20:35:50]

nice, lgtm

https://codereview.chromium.org/1969263004/diff/80001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/1969263004/diff/80001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_android.cc:1467: // It
does not use a deadline.
nit: s/it's/its or rather maybe update the comment to be more specific (or
remove that vague part about 'doing work')

https://codereview.chromium.org/1969263004/diff/80001/content/renderer/androi...
File content/renderer/android/synchronous_compositor_filter.cc (right):

https://codereview.chromium.org/1969263004/diff/80001/content/renderer/androi...
content/renderer/android/synchronous_compositor_filter.cc:255: // TODO(boliu):
refactor this
nit: how/why? :)

https://codereview.chromium.org/1969263004/diff/80001/content/renderer/androi...
File content/renderer/android/synchronous_compositor_proxy.cc (right):

https://codereview.chromium.org/1969263004/diff/80001/content/renderer/androi...
content/renderer/android/synchronous_compositor_proxy.cc:244: // It is possible
to get this called twice, eg if draw is called before
nits:
'for this to get called'
s/'eg'/'eg.' 
duplciated typo below

[boliu, 2016-06-03 21:01:06]

https://codereview.chromium.org/1969263004/diff/80001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/1969263004/diff/80001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_android.cc:1467: // It
does not use a deadline.
On 2016/06/03 20:35:50, sievers wrote:
> nit: s/it's/its or rather maybe update the comment to be more specific (or
> remove that vague part about 'doing work')

rewored

https://codereview.chromium.org/1969263004/diff/80001/content/renderer/androi...
File content/renderer/android/synchronous_compositor_filter.cc (right):

https://codereview.chromium.org/1969263004/diff/80001/content/renderer/androi...
content/renderer/android/synchronous_compositor_filter.cc:255: // TODO(boliu):
refactor this
On 2016/06/03 20:35:50, sievers wrote:
> nit: how/why? :)

We don't need "Entry" anymore, since Entry is really only holding one thing now

but thought such a refactor would polute this CL a bit too much

https://codereview.chromium.org/1969263004/diff/80001/content/renderer/androi...
File content/renderer/android/synchronous_compositor_proxy.cc (right):

https://codereview.chromium.org/1969263004/diff/80001/content/renderer/androi...
content/renderer/android/synchronous_compositor_proxy.cc:244: // It is possible
to get this called twice, eg if draw is called before
On 2016/06/03 20:35:50, sievers wrote:
> nits:
> 'for this to get called'
> s/'eg'/'eg.' 
> duplciated typo below

Done.

[boliu, 2016-06-03 21:24:16]

boliu@chromium.org changed reviewers:
+ dcheng@chromium.org

[boliu, 2016-06-03 21:24:16]

+dcheng for ipc

Note I rebased this onto https://codereview.chromium.org/1974133002/, so need to
wait for that one to land first. These two actually conflict quite a bit :)

[dcheng, 2016-06-03 21:26:23]

LGTM

[boliu, 2016-06-03 23:41:36]

The CQ bit was checked by boliu@chromium.org

[boliu, 2016-06-03 23:41:36]

The patchset sent to the CQ was uploaded after l-g-t-m from sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1969263004/#ps140001
(title: "rebase onto https://codereview.chromium.org/1974133002/")

[commit-bot: I haz the power, 2016-06-03 23:42:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1969263004/140001

[commit-bot: I haz the power, 2016-06-04 00:59:33]

Description was changed from

==========
sync compositor: Remove begin frame source

Share the same BeginFrameSource implementation with chrome.

The old synchronous begin frame IPC is split into two parts:
an async begin frame IPC (shared with rest of chrome),
and a sync IPC to synchronously retrieve the renderer state.

Note needs_begin_frame is no longer part of the synchronous
state retrieved from renderer. This is ok because input
is already async and that's the only time when having an
up-to-date needs_begin_frame really matters.

This removes the whole synchronous compositor "IsActive"
concept since it's superceded completely by visibility.

BUG=609977
==========

to

==========
sync compositor: Remove begin frame source

Share the same BeginFrameSource implementation with chrome.

The old synchronous begin frame IPC is split into two parts:
an async begin frame IPC (shared with rest of chrome),
and a sync IPC to synchronously retrieve the renderer state.

Note needs_begin_frame is no longer part of the synchronous
state retrieved from renderer. This is ok because input
is already async and that's the only time when having an
up-to-date needs_begin_frame really matters.

This removes the whole synchronous compositor "IsActive"
concept since it's superceded completely by visibility.

BUG=609977
==========

[commit-bot: I haz the power, 2016-06-04 00:59:36]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-06-04 01:00:44]

Description was changed from

==========
sync compositor: Remove begin frame source

Share the same BeginFrameSource implementation with chrome.

The old synchronous begin frame IPC is split into two parts:
an async begin frame IPC (shared with rest of chrome),
and a sync IPC to synchronously retrieve the renderer state.

Note needs_begin_frame is no longer part of the synchronous
state retrieved from renderer. This is ok because input
is already async and that's the only time when having an
up-to-date needs_begin_frame really matters.

This removes the whole synchronous compositor "IsActive"
concept since it's superceded completely by visibility.

BUG=609977
==========

to

==========
sync compositor: Remove begin frame source

Share the same BeginFrameSource implementation with chrome.

The old synchronous begin frame IPC is split into two parts:
an async begin frame IPC (shared with rest of chrome),
and a sync IPC to synchronously retrieve the renderer state.

Note needs_begin_frame is no longer part of the synchronous
state retrieved from renderer. This is ok because input
is already async and that's the only time when having an
up-to-date needs_begin_frame really matters.

This removes the whole synchronous compositor "IsActive"
concept since it's superceded completely by visibility.

BUG=609977

Committed: https://crrev.com/8f3016ee733ac3e4ccd65e0711f5d3a9b92e5e49
Cr-Commit-Position: refs/heads/master@{#397874}
==========

[commit-bot: I haz the power, 2016-06-04 01:00:46]

Patchset 8 (id:??) landed as
https://crrev.com/8f3016ee733ac3e4ccd65e0711f5d3a9b92e5e49
Cr-Commit-Position: refs/heads/master@{#397874}