Issue 1969263002: Fix the no-i18n build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1969263002: Fix the no-i18n build (Closed)

Created:
4 years, 7 months ago by Dan Ehrenberg

Modified:
4 years, 7 months ago

Reviewers:
adamk

CC:
v8-reviews_googlegroups.com, Michael Achenbach

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix the no-i18n build TBR=adamk@chromium.org Committed: https://crrev.com/2e8c3c9e2b3d0c78ac7a7f623d95fb9c69a96ff8 Cr-Commit-Position: refs/heads/master@{#36191}

Patch Set 1 #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	BUILD.gn	View		2 chunks	+4 lines, -2 lines	0 comments	Download
	M	src/v8.gyp	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969263002/1

4 years, 7 months ago (2016-05-12 01:57:43 UTC) #2

commit-bot: I haz the power

4 years, 7 months ago (2016-05-12 02:42:53 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/2e8c3c9e2b3d0c78ac7a7f623d95fb9c69a96ff8
Cr-Commit-Position: refs/heads/master@{#36191}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages