chrome/browser/android/offline_pages/offline_page_bridge.h - Issue 1969233002: [OfflinePages] Make website settings popup rely on asynchronous API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/offline_page_bridge.h

Issue 1969233002: [OfflinePages] Make website settings popup rely on asynchronous API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resolving code review comments and running git cl format Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java ('k') | chrome/browser/android/offline_pages/offline_page_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/offline_page_bridge.h

diff --git a/chrome/browser/android/offline_pages/offline_page_bridge.h b/chrome/browser/android/offline_pages/offline_page_bridge.h

index 5d1d21d4dc18a0f027d00633fb11aac6fbf5f4c1..034636ebaed99fd78106883aaf64e3693fa5b3b5 100644

--- a/chrome/browser/android/offline_pages/offline_page_bridge.h

+++ b/chrome/browser/android/offline_pages/offline_page_bridge.h

@@ -71,10 +71,11 @@ class OfflinePageBridge : public OfflinePageModel::Observer,

const base::android::JavaParamRef<jobject>& obj,

const base::android::JavaParamRef<jstring>& online_url);

- base::android::ScopedJavaLocalRef<jobject> GetPageByOfflineUrl(

+ void GetPageByOfflineUrl(

JNIEnv* env,

const base::android::JavaParamRef<jobject>& obj,

- const base::android::JavaParamRef<jstring>& j_offline_url);

+ const base::android::JavaParamRef<jstring>& j_offline_url,

+ const base::android::JavaParamRef<jobject>& j_callback_obj);

void SavePage(

JNIEnv* env,

@@ -112,10 +113,6 @@ class OfflinePageBridge : public OfflinePageModel::Observer,

private:

void NotifyIfDoneLoading() const;

- base::android::ScopedJavaLocalRef<jobject> CreateOfflinePageItem(

- JNIEnv* env,

- const OfflinePageItem& offline_page) const;

base::android::ScopedJavaLocalRef<jobject> CreateClientId(

JNIEnv* env,

const ClientId& clientId) const;