[OfflinePages] Make website settings popup rely on asynchronous API

chrome/browser/android/offline_pages/offline_page_bridge.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_BRIDGE_H_
 #define CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_BRIDGE_H_
 
 #include <stdint.h>
 
 #include "base/android/jni_android.h"
@@ skipping 53 matching lines @@
   base::android::ScopedJavaLocalRef<jobject> GetPageByOfflineId(
       JNIEnv* env,
       const base::android::JavaParamRef<jobject>& obj,
       jlong offline_id);
 
   base::android::ScopedJavaLocalRef<jobject> GetBestPageForOnlineURL(
       JNIEnv* env,
       const base::android::JavaParamRef<jobject>& obj,
       const base::android::JavaParamRef<jstring>& online_url);
 
-  base::android::ScopedJavaLocalRef<jobject> GetPageByOfflineUrl(
+  void GetPageByOfflineUrl(
       JNIEnv* env,
       const base::android::JavaParamRef<jobject>& obj,
-      const base::android::JavaParamRef<jstring>& j_offline_url);
+      const base::android::JavaParamRef<jstring>& j_offline_url,
+      const base::android::JavaParamRef<jobject>& j_callback_obj);
 
   void SavePage(
       JNIEnv* env,
       const base::android::JavaParamRef<jobject>& obj,
       const base::android::JavaParamRef<jobject>& j_callback_obj,
       const base::android::JavaParamRef<jobject>& j_web_contents,
       const base::android::JavaParamRef<jstring>& j_namespace,
       const base::android::JavaParamRef<jstring>& j_client_id);
 
   void SavePageLater(
@@ skipping 17 matching lines @@
                                const base::android::JavaParamRef<jobject>& obj,
                                jlong total_space_bytes,
                                jlong free_space_bytes,
                                jboolean reporting_after_delete);
 
   base::android::ScopedJavaGlobalRef<jobject> java_ref() { return java_ref_; }
 
  private:
   void NotifyIfDoneLoading() const;
 
   base::android::ScopedJavaLocalRef<jobject> CreateOfflinePageItem(

[fgorski, 2016/05/17 04:12:25]

did you mean to remove this? I think you are deleting the method.

[chili, 2016/05/17 17:53:30]

Done.

       JNIEnv* env,
       const OfflinePageItem& offline_page) const;
 
   base::android::ScopedJavaLocalRef<jobject> CreateClientId(
       JNIEnv* env,
       const ClientId& clientId) const;
 
   base::android::ScopedJavaGlobalRef<jobject> java_ref_;
   // Not owned.
   content::BrowserContext* browser_context_;
   // Not owned.
   OfflinePageModel* offline_page_model_;
 
   DISALLOW_COPY_AND_ASSIGN(OfflinePageBridge);
 };
 
 bool RegisterOfflinePageBridge(JNIEnv* env);
 
 }  // namespace android
 }  // namespace offline_pages
 
 #endif  // CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_BRIDGE_H_