Ignore whitelist when generating android xml.

Ignore whitelist when generating android xml.

Whitelist should only apply to the resources used outside of Java.
This helps us to only need to specify the whitelist for C++ resources
without affecting Android XML file generation.

BUG=338759
Patch from issue 196273004, landing for aurimas@chromium.org

Committed: https://code.google.com/p/grit-i18n/source/detail?r=156

[Jói, 2014-03-12 09:21:09]

Landing for you, TBRing.

[Jói, 2014-03-12 09:21:30]

Committed patchset #1 manually as r156 (presubmit successful).

[johannesa, 2014-03-25 14:22:18]

On 2014/03/12 09:21:30, Jói wrote:
> Committed patchset #1 manually as r156 (presubmit successful).

I'm not sure that this CL is correct. 

Changing iteration from node.ActiveDescendants to node.Preorder makes grit
ignore all node expressions in the grd-file when exporting to xml.

At Opera we share some grd files between platforms, and we use <if
expr=...>-nodes to target each platform. With this CL all nodes are exported
without evaluating the node expressions. Since some of our expressions includes
child nodes with the same ID, we get multiple definitions in our xml output
file.

Is this behaviour intended?

[Jói, 2014-03-25 14:35:17]

On 2014/03/25 14:22:18, johannesa wrote:
> On 2014/03/12 09:21:30, Jói wrote:
> > Committed patchset #1 manually as r156 (presubmit successful).
> 
> I'm not sure that this CL is correct. 
> 
> Changing iteration from node.ActiveDescendants to node.Preorder makes grit
> ignore all node expressions in the grd-file when exporting to xml.
> 
> At Opera we share some grd files between platforms, and we use <if
> expr=...>-nodes to target each platform. With this CL all nodes are exported
> without evaluating the node expressions. Since some of our expressions
includes
> child nodes with the same ID, we get multiple definitions in our xml output
> file.
> 
> Is this behaviour intended?

I'm not sure, but neither was I aware that this would cause expressions to get
ignored.

Aurimas, what do you think?

Cheers,
Jói

[newt (away), 2014-03-25 14:50:35]

On 2014/03/25 14:35:17, Jói wrote:
> On 2014/03/25 14:22:18, johannesa wrote:
> > On 2014/03/12 09:21:30, Jói wrote:
> > > Committed patchset #1 manually as r156 (presubmit successful).
> > 
> > I'm not sure that this CL is correct. 
> > 
> > Changing iteration from node.ActiveDescendants to node.Preorder makes grit
> > ignore all node expressions in the grd-file when exporting to xml.
> > 
> > At Opera we share some grd files between platforms, and we use <if
> > expr=...>-nodes to target each platform. With this CL all nodes are exported
> > without evaluating the node expressions. Since some of our expressions
> includes
> > child nodes with the same ID, we get multiple definitions in our xml output
> > file.
> > 
> > Is this behaviour intended?
> 
> I'm not sure, but neither was I aware that this would cause expressions to get
> ignored.
> 
> Aurimas, what do you think?
> 
> Cheers,
> Jói

The intention was to ignore the whitelist, but not to ignore <if> expressions in
general. If android_xml is now ignoring all <if> statements, we'll probably need
to revert this and come up with a different solution to the problem this was
supposed to solve.

[aurimas (slooooooooow), 2014-03-25 21:21:59]

A revert of this CL has been created in
https://codereview.chromium.org/211743003/ by aurimas@chromium.org.

The reason for reverting is: This CL breaks the <if expr=""> for Android XML
generation..