Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1969223002: Use polling to test Physical Web upgrade path (Closed)

Created:
4 years, 7 months ago by cco3
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use polling to test Physical Web upgrade path Our upgrade test is failing on some devices. It could be a race condition that makes waitForIdleSync insufficient. If this is indeed the issue, using CriteriaHelper should fix the problem. BUG=597316 Committed: https://crrev.com/fe8947ed378f5a0ba7c602dbae38864d73a6b0f1 Cr-Commit-Position: refs/heads/master@{#393352}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java View 2 chunks +15 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
cco3
4 years, 7 months ago (2016-05-12 00:36:06 UTC) #2
cco3
4 years, 7 months ago (2016-05-12 00:38:24 UTC) #4
mattreynolds
lgtm
4 years, 7 months ago (2016-05-12 00:50:35 UTC) #5
cco3
4 years, 7 months ago (2016-05-12 00:50:59 UTC) #7
nyquist
lgtm for now, but it'd be nice to know why this fails. have you been ...
4 years, 7 months ago (2016-05-12 20:03:34 UTC) #8
cco3
On 2016/05/12 20:03:34, nyquist wrote: > lgtm for now, but it'd be nice to know ...
4 years, 7 months ago (2016-05-12 20:24:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969223002/1
4 years, 7 months ago (2016-05-12 20:31:59 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 21:04:59 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 21:06:02 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe8947ed378f5a0ba7c602dbae38864d73a6b0f1
Cr-Commit-Position: refs/heads/master@{#393352}

Powered by Google App Engine
This is Rietveld 408576698