Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1969203003: Move makeChildrenInlineIfPossible to LayoutBlockFlow (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
eae, szager1, wkorman
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move makeChildrenInlineIfPossible to LayoutBlockFlow It's now possible to move makeChildrenInlineIfPossible() to LayoutBlockFlow. BUG=302024 Committed: https://crrev.com/a755dbddc0d29de8003c704416a99d00e60ec230 Cr-Commit-Position: refs/heads/master@{#393390}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -46 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 chunk +0 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-12 22:31:51 UTC) #2
eae
LGTM
4 years, 7 months ago (2016-05-12 22:33:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969203003/1
4 years, 7 months ago (2016-05-12 22:33:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 23:19:26 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 23:22:05 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a755dbddc0d29de8003c704416a99d00e60ec230
Cr-Commit-Position: refs/heads/master@{#393390}

Powered by Google App Engine
This is Rietveld 408576698