cast_test_utility needs a dependency on media_features

cast_test_utility needs a dependency on media_features

Some files in this target include a generated media_features.h header
indirectly through other media headers. So we need an explicit
dependency on the media_features target, to ensure the media_features.h
header is generated.

Committed: https://crrev.com/e444eb0eeb204dfc5e7bc59cd7931c124451a29b
Cr-Commit-Position: refs/heads/master@{#393723}

[servolk, 2016-05-11 21:31:23]

Description was changed from

==========
cast_test_utility needs a dependency on media_features

Some files in this target include a generated media_features.h header
indirectly through other media headers. So we need an explicit
dependency on the media_features target, to ensure the media_features.h
header is generated.
==========

to

==========
cast_test_utility needs a dependency on media_features

Some files in this target include a generated media_features.h header
indirectly through other media headers. So we need an explicit
dependency on the media_features target, to ensure the media_features.h
header is generated.
==========

[servolk, 2016-05-11 21:31:23]

servolk@chromium.org changed reviewers:
+ miu@chromium.org

[servolk, 2016-05-12 16:56:30]

On 2016/05/11 21:32:37, servolk wrote:

ping

[servolk, 2016-05-12 22:09:40]

On 2016/05/12 16:56:30, servolk wrote:
> On 2016/05/11 21:32:37, servolk wrote:
> 
> ping

ping

[servolk, 2016-05-13 18:55:31]

On 2016/05/12 22:09:40, servolk wrote:
> On 2016/05/12 16:56:30, servolk wrote:
> > On 2016/05/11 21:32:37, servolk wrote:
> > 
> > ping
> 
> ping

ping

[miu, 2016-05-13 22:43:08]

lgtm, but do we need BUILD.gn changes too?

[servolk, 2016-05-13 22:53:47]

On 2016/05/13 22:43:08, miu wrote:
> lgtm, but do we need BUILD.gn changes too?

I believe GN is better at tracking transitive dependencies than GYP, so we
probably don't need to change anything for GN. In GN world the
//media/cast:test_support target, which corresponds to cast_test_utility GYP
target, already has a dependency on //media:test_support -> //media ->
//media:media_features.
For GYP we needed to add this explicit dependency because even though
media_test_support depends on media_features, it is not marked as
hard_dependency, and so we still saw occasional build flakiness (see
crbug.com/606829).

[servolk, 2016-05-13 22:53:55]

The CQ bit was checked by servolk@chromium.org

[commit-bot: I haz the power, 2016-05-13 22:54:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1969173002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1969173002/1

[commit-bot: I haz the power, 2016-05-14 01:22:26]

Description was changed from

==========
cast_test_utility needs a dependency on media_features

Some files in this target include a generated media_features.h header
indirectly through other media headers. So we need an explicit
dependency on the media_features target, to ensure the media_features.h
header is generated.
==========

to

==========
cast_test_utility needs a dependency on media_features

Some files in this target include a generated media_features.h header
indirectly through other media headers. So we need an explicit
dependency on the media_features target, to ensure the media_features.h
header is generated.
==========

[commit-bot: I haz the power, 2016-05-14 01:22:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-14 01:24:12]

Description was changed from

==========
cast_test_utility needs a dependency on media_features

Some files in this target include a generated media_features.h header
indirectly through other media headers. So we need an explicit
dependency on the media_features target, to ensure the media_features.h
header is generated.
==========

to

==========
cast_test_utility needs a dependency on media_features

Some files in this target include a generated media_features.h header
indirectly through other media headers. So we need an explicit
dependency on the media_features target, to ensure the media_features.h
header is generated.

Committed: https://crrev.com/e444eb0eeb204dfc5e7bc59cd7931c124451a29b
Cr-Commit-Position: refs/heads/master@{#393723}
==========

[commit-bot: I haz the power, 2016-05-14 01:24:13]

Patchset 1 (id:??) landed as
https://crrev.com/e444eb0eeb204dfc5e7bc59cd7931c124451a29b
Cr-Commit-Position: refs/heads/master@{#393723}