Issue 19691005: Remove HCompareConstantEqAndBranch (never used), and its corresponding Lithium instructions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19691005: Remove HCompareConstantEqAndBranch (never used), and its corresponding Lithium instructions. (Closed)

Created:
7 years, 5 months ago by titzer

Modified:
7 years, 5 months ago

Reviewers:
Benedikt Meurer, mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Remove HCompareConstantEqAndBranch (never used), and its corresponding Lithium instructions. BUG= R=bmeurer@chromium.org, mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15853

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -143 lines)			Patch
M	src/arm/lithium-arm.h	View	2 chunks	+0 lines, -15 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	2 chunks	+0 lines, -24 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View	2 chunks	+0 lines, -15 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/mips/lithium-mips.h	View	2 chunks	+0 lines, -15 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/x64/lithium-x64.h	View	2 chunks	+0 lines, -15 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Total messages: 4 (0 generated)

mvstanton

That is good. Our other comparison operations are smart enough to recognize an HConstant and ...

7 years, 5 months ago (2013-07-24 09:57:29 UTC) #2

titzer

7 years, 5 months ago (2013-07-24 10:48:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r15853 (presubmit successful).