Miscellaneous runtime fixes.

Miscellaneous runtime fixes.

Shaves some time off of the sample app startup.

BUG=
R=jmesserly@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/083713468cb7696cb3cde8d101b874a5da64d84d

[Leaf, 2016-05-11 19:40:58]

leafp@google.com changed reviewers:
+ jmesserly@google.com, sra@google.com

[Jennifer Messerly, 2016-05-11 19:56:26]

Well it's kind of a shame to see more crazy-interpolation-JS-functions-in-Dart,
but otherwise LGTM.

https://codereview.chromium.org/1969093002/diff/1/tool/input_sdk/private/ddc_...
File tool/input_sdk/private/ddc_runtime/classes.dart (right):

https://codereview.chromium.org/1969093002/diff/1/tool/input_sdk/private/ddc_...
tool/input_sdk/private/ddc_runtime/classes.dart:290: for (var i = 0; i <
names.length; ++i) {
nit: use `let` if writing JS code

https://codereview.chromium.org/1969093002/diff/1/tool/input_sdk/private/ddc_...
tool/input_sdk/private/ddc_runtime/classes.dart:291: let name = names[i];
fyi ... there is a way to write this in Dart without converting it back to the
old pattern (that I've been slowly trying to remove).

This would work:

var names = getOwnPropertyNames(coreObjProto);
for (int i = 0; i < JS('int', '#.length', names); ++i) {
    var name = JS('', '#[#], names, i);
    ...
}


That said, if we're microoptimizing, maybe we need to convert large chunks of
the runtime back to a .js file.

https://codereview.chromium.org/1969093002/diff/1/tool/input_sdk/private/ddc_...
File tool/input_sdk/private/ddc_runtime/utils.dart (right):

https://codereview.chromium.org/1969093002/diff/1/tool/input_sdk/private/ddc_...
tool/input_sdk/private/ddc_runtime/utils.dart:96: for (var i = 0; i <
$names.length; ++i) {
nit: use `let`

[Leaf, 2016-05-12 00:20:44]

Description was changed from

==========
Miscellaneous runtime fixes.

Shaves some time off of the sample app startup.

BUG=
==========

to

==========
Miscellaneous runtime fixes.

Shaves some time off of the sample app startup.

BUG=
R=jmesserly@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/083713468cb7696cb3cde8d101b8...
==========

[Leaf, 2016-05-12 00:20:45]

Committed patchset #2 (id:20001) manually as
083713468cb7696cb3cde8d101b874a5da64d84d (presubmit successful).

[Leaf, 2016-05-12 17:00:44]

https://codereview.chromium.org/1969093002/diff/1/tool/input_sdk/private/ddc_...
File tool/input_sdk/private/ddc_runtime/classes.dart (right):

https://codereview.chromium.org/1969093002/diff/1/tool/input_sdk/private/ddc_...
tool/input_sdk/private/ddc_runtime/classes.dart:290: for (var i = 0; i <
names.length; ++i) {
On 2016/05/11 19:56:26, John Messerly wrote:
> nit: use `let` if writing JS code

Done.

https://codereview.chromium.org/1969093002/diff/1/tool/input_sdk/private/ddc_...
tool/input_sdk/private/ddc_runtime/classes.dart:291: let name = names[i];
On 2016/05/11 19:56:26, John Messerly wrote:
> fyi ... there is a way to write this in Dart without converting it back to the
> old pattern (that I've been slowly trying to remove).
> 
> This would work:
> 
> var names = getOwnPropertyNames(coreObjProto);
> for (int i = 0; i < JS('int', '#.length', names); ++i) {
>     var name = JS('', '#[#], names, i);
>     ...
> }
> 
> 
> That said, if we're microoptimizing, maybe we need to convert large chunks of
> the runtime back to a .js file.

Done.

https://codereview.chromium.org/1969093002/diff/1/tool/input_sdk/private/ddc_...
File tool/input_sdk/private/ddc_runtime/utils.dart (right):

https://codereview.chromium.org/1969093002/diff/1/tool/input_sdk/private/ddc_...
tool/input_sdk/private/ddc_runtime/utils.dart:96: for (var i = 0; i <
$names.length; ++i) {
On 2016/05/11 19:56:26, John Messerly wrote:
> nit: use `let`

Done.